feat: refactor local function to use AsRef, simplify write arguments #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gankra
approved these changes
May 2, 2023
shadows-withal
changed the title
shadows-withal
force-pushed
the
feat/local-func-sigs
branch
from
8d9a28f
to
35f3923
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the signature of those two functions to not explicitly take a
filenameand adest_dirargument, instead now taking adest_pathargument, from which we infer everything else.These two functions aren't currently in use in axo code (outside of axodotdev/cargo-dist#229), so changing the signatures should be fine, at least for our use, as long as we mark the change as breaking correspondingly.