Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Extension Package to AsyncPackage #206

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

chrish619
Copy link

@chrish619 chrish619 commented Aug 13, 2019

Fixes #204

  • Allows further updates / versions to be accepted by Extensions Marketplace
  • Allows running in Visual Studio 2019, without legacy/deprecated API issues

Breaking changes

  • C++ Build tools now target v140 (Visual Studio 2015)
  • Removes any support for Visual Studio versions pre 2015

Other changes

  • Move from VSSDK Helper packages to source packages - This allows direct targeting of API & reduces additional "noise" when including the current versions, e.g. Helper packages *.11 requires *.10, requires *.9 etc

@CLAassistant
Copy link

CLAassistant commented Aug 13, 2019

CLA assistant check
All committers have signed the CLA.

@MABrunner
Copy link

This looks great!! Can someone review?

Copy link

@malcolmarobertson malcolmarobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't comment on the code but I cloned and built the project using VS 2019 v16.2.3
But, built the project with upgrading WindowsTargetPlatformVersion to 10 and PlatformToolset to v142
The VSIX works perfectly on VS 2019 with Xunit 4.2.1

@axodox
Copy link
Owner

axodox commented Aug 25, 2019

I think I will need to create a new AxoCover entry in the marketplace, since this would break the old VS support, and I would like to avoid that.

@jgasiorowski
Copy link

@chrish619 Thanks for that work - works like a charm. I pulled it to my repository to be used with other features and just build my local vsix package and using it on daily basis. Thanks

@m-ringler
Copy link

I'd love to see this on VS marketplace.

@jgasiorowski
Copy link

Author of that plugin does not really respond on any comments. I really don't know what needs to be done to put that on VS Marketplace - I don't even know if I am allowed to put that under new name/account. Noone really want to take Axodox's glory :)

@axodox
Copy link
Owner

axodox commented Feb 14, 2020

Since this plugin version is no longer compatible with old VS I think it should be uploaded as a separate entry in VS marketplace (e.g. AxoCover Next). Unfortunately I am having some health issues since last year, and it is hard for me to even do what is needed at my workplace, much less for free time.

At this point the best way would be to create an organization on github, and let the community manage AxoCover in the future.

@jgasiorowski
Copy link

@axodox , sorry to hear that. I really hope you will get better 😟. I don't have much time and all that things 'organisation on github' is new to me. But if I will find enough time then I will be happy to try that. Thanks for permission

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning on Open with VS2019 Plugin
7 participants