Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Prediction (Table) Artifacts to MLFlow Logger #1505

Closed
5 tasks done
DavidFarago opened this issue Apr 9, 2024 · 1 comment
Closed
5 tasks done

Add Prediction (Table) Artifacts to MLFlow Logger #1505

DavidFarago opened this issue Apr 9, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@DavidFarago
Copy link
Contributor

⚠️ Please check that this feature request hasn't been suggested before.

  • I searched previous Ideas in Discussions didn't find any similar feature requests.
  • I searched previous Issues didn't find any similar feature requests.

🔖 Feature description

Generalize #490 to log to MLFlow, too.

✔️ Solution

If MLFlow is configured, I want a LogPredictionCallback to log to the configured MLFlow.

❓ Alternatives

No response

📝 Additional Context

No response

Acknowledgements

  • My issue title is concise, descriptive, and in title casing.
  • I have searched the existing issues to make sure this feature has not been requested yet.
  • I have provided enough information for the maintainers to understand and evaluate this request.
@DavidFarago DavidFarago added the enhancement New feature or request label Apr 9, 2024
DavidFarago pushed a commit to DavidFarago/axolotl that referenced this issue Apr 9, 2024
WIP: Support table logging for mlflow, too
2b87bde 
Create a `LogPredictionCallback` for both "wandb" and "mlflow" if
specified.

In `log_prediction_callback_factory`, create a generic table and make it
specific only if the newly added `logger` argument is set to "wandb"
resp. "mlflow".

See axolotl-ai-cloud#1505
@DavidFarago DavidFarago mentioned this issue Apr 9, 2024
Merged
winglian added a commit that referenced this issue Apr 9, 2024
@DavidFarago @winglian
WIP: Support table logging for mlflow, too (#1506)
057fa44 
* WIP: Support table logging for mlflow, too

Create a `LogPredictionCallback` for both "wandb" and "mlflow" if
specified.

In `log_prediction_callback_factory`, create a generic table and make it
specific only if the newly added `logger` argument is set to "wandb"
resp. "mlflow".

See #1505

* chore: lint

* add additional clause for mlflow as it's optional

* Fix circular imports

---------

Co-authored-by: Dave Farago <dfarago@innoopract.com>
Co-authored-by: Wing Lian <wing.lian@gmail.com>
@DavidFarago
Copy link
Contributor Author

Thanks @winglian for your help.

@DavidFarago DavidFarago mentioned this issue Apr 16, 2024
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DavidFarago