Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow remote data paths #1278

Merged
merged 5 commits into from
Feb 8, 2024
Merged

allow remote data paths #1278

merged 5 commits into from
Feb 8, 2024

Conversation

hamelsmu
Copy link
Collaborator

@hamelsmu hamelsmu commented Feb 8, 2024

This ended up being pretty simple. Added support for remote URL paths per discussion with @winglian - HF Datasets natively allow remote paths

@hamelsmu hamelsmu requested a review from winglian February 8, 2024 21:52
src/axolotl/utils/data.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@winglian winglian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, only consideration might be the security of allowing unsecured http connections.

@hamelsmu hamelsmu merged commit 91cf4ee into main Feb 8, 2024
7 checks passed
djsaunde pushed a commit that referenced this pull request Dec 17, 2024
* allow remote data paths

* add docs about public url

* only allow https

* better docs

* better docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants