Allow load_best_model_at_end to be configured for early stopping on custom evaluation datasets #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e is zero for custom evaluation datasets
8 tasks
winglian
approved these changes
Feb 16, 2024
|
Hey! Please let us know if you need help running lint. You can find a short guide on how to set it up here: https://github.com/OpenAccess-AI-Collective/axolotl?tab=readme-ov-file#contributing- |
8 tasks
|
@winglian @NanoCode012 apologies for not installing the hooks and noticing the lint issue. Hopefully this is good now. Thanks for all you do with Axolotl, it is a really great project |
chiragjn
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds an additional clause when configuring the trainer to allow load_best_model_at_end to be set when using custom evaluation datasets (i.e. test_datasets is populated and val_set_size is to zero).
Motivation and Context
When using a custom test dataset for evaluation was unable to set early_stopping_patience as load_best_model_at_end was never set on the training configuration. This change allows the early stopping callback to be configured in the trainer successful.
How has this been tested?
I have been using this successfully for various training runs for models.