Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support galore once upstreamed into transformers #1409

Merged
merged 8 commits into from
Mar 19, 2024
Merged

support galore once upstreamed into transformers #1409

merged 8 commits into from
Mar 19, 2024

Conversation

winglian
Copy link
Collaborator

Supersedes #1370, pending merging of Galore upstream in transformers. We'll also need to bump transformers in our requirements once that is merged upstream.

huggingface/transformers#29588

@winglian winglian merged commit dd449c5 into main Mar 19, 2024
6 checks passed
@winglian winglian deleted the galore-v2 branch March 19, 2024 13:26
@winglian winglian mentioned this pull request Mar 19, 2024
@fakerybakery
Copy link

Hi, super excited to try this out! Is there an example config file?

@winglian
Copy link
Collaborator Author

Hi, super excited to try this out! Is there an example config file?

optimizer: galore_adamw | galore_adamw_8bit | galore_adafactor
optim_args:
  rank: 128
  update_proj_gap: 200
  scale: 0.25
  proj_type: std
optim_target_modules:
  - mlp
  - attn

seungduk-yanolja pushed a commit to Y-IAB/axolotl that referenced this pull request Mar 19, 2024
* support galore once upstreamed into transformers

* update module name for llama in readme and fix typing for all linear

* bump trl for deprecation fixes from newer transformers

* include galore as an extra and install in docker image

* fix optim_args type

* fix optim_args

* update dependencies for galore

* add galore to cicd dockerfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants