New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn on sample_packing for Gemma training #1438

Merged

winglian merged 1 commit into axolotl-ai-cloud:main from satpalsr:patch-1

Mar 26, 2024

Contributor

satpalsr commented Mar 25, 2024

In last commit, sample_packing was entirely turned off #1405
However, only eval_sample_packing must be kept false here.


          turn sample_packing on for training

9ccc22b

winglian force-pushed the patch-1 branch from 688dc5d to 9ccc22b Compare

March 26, 2024 17:44

winglian approved these changes

View reviewed changes

Collaborator

winglian left a comment

good catch. thanks!

winglian added the ready to merge label

winglian merged commit c19d060 into axolotl-ai-cloud:main

satpalsr deleted the patch-1 branch

March 27, 2024 02:57

djsaunde pushed a commit that referenced this pull request


          turn sample_packing on for training (#1438) [skip ci]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels