Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure to save on the last step #1615

Merged
merged 1 commit into from
May 14, 2024
Merged

make sure to save on the last step #1615

merged 1 commit into from
May 14, 2024

Conversation

winglian
Copy link
Collaborator

@winglian winglian commented May 14, 2024

fixes #1613

Due to rounding, the default trainer code may not properly save on the final step.
Screenshot 2024-05-14 at 7 46 05 AM

@winglian winglian mentioned this pull request May 14, 2024
8 tasks
@winglian winglian merged commit 1634ac8 into main May 14, 2024
7 checks passed
@winglian winglian deleted the save-last-step branch May 14, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail to save last checkpoint
1 participant