Fix: modelloader handling of model_kwargs load_in*bit #1999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NanoCode012
changed the title
NanoCode012
force-pushed
the
fix/model-loader-cast-issues
branch
from
0b34c27
to
485eab8
Compare
|
This looks much better than checking if the key-value pair exists before each check. :-) |
|
To validate the new e2e test, I ran it on current
|
winglian
force-pushed
the
fix/model-loader-cast-issues
branch
from
2d7a2fe
to
fc0cb6a
Compare
winglian
approved these changes
Oct 30, 2024
bursteratom
pushed a commit
that referenced
this pull request
Nov 18, 2024
* fix: load_in_*bit not properly read * fix: load_*bit check * fix: typo * refactor: load * bit handling * feat: add test dpo lora multi-gpu * fix: turn off sample packing for dpo * fix: missing warmup_steps * fix: test to load in 8bit for lora * skip 8bit lora on h100, add 4bit lora on h100 to multi gpu tests * chore: reduce max_steps --------- Co-authored-by: Wing Lian <wing.lian@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I missed one important case where
model_kwargs["load_in_8bit"]andmodel_kwargs["load_in_4bit"]are deleted at the end ofself.set_quantization_config()which would break all further dependency on the above kwarg. This PR fixes that and refactors the handling.Motivation and Context
How has this been tested?
Screenshots (if appropriate)
Types of changes
Social Handles (Optional)