Fix get_chat_template call for trainer builder #2003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NanoCode012
reviewed
Oct 30, 2024
| @@ -272,7 +272,7 @@ def do_inference_gradio( | |||
| importlib.import_module("axolotl.prompters"), prompter | |||
| ) | |||
| elif cfg.chat_template: | |||
| chat_template_str = get_chat_template(cfg.chat_template) | |||
| chat_template_str = get_chat_template(cfg.chat_template, tokenizer=tokenizer) | |||
There was a problem hiding this comment.
Nice catch. While testing this, I got this error but figured it was due to my tokenizer chosen not having a template in its config.
NanoCode012
approved these changes
Oct 30, 2024
bursteratom
pushed a commit
that referenced
this pull request
Nov 18, 2024
djsaunde
pushed a commit
that referenced
this pull request
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Code crashes when choosing
chat_template: tokenizer_defaultWe missed a few places in previous PRs
Social Handles (Optional)
@NanoCode012