Update unsloth for torch.cuda.amp deprecation #2042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
it seems that these changes causes some subset of the test matrix to take significantly longer to complete. |
added 2 commits
November 13, 2024 09:16
winglian
reviewed
Nov 13, 2024
|
winglian
approved these changes
Nov 13, 2024
bursteratom
added a commit
that referenced
this pull request
Nov 18, 2024
* update deprecated unsloth tirch cuda amp decorator * WIP fix torch.cuda.amp deprecation * lint * laxing torch version requirement * remove use of partial * remove use of partial * lint --------- Co-authored-by: sunny <sunnyliu19981005@gmail.com>
djsaunde
pushed a commit
that referenced
this pull request
Dec 17, 2024
* update deprecated unsloth tirch cuda amp decorator * WIP fix torch.cuda.amp deprecation * lint * laxing torch version requirement * remove use of partial * remove use of partial * lint --------- Co-authored-by: sunny <sunnyliu19981005@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
torch.cuda.amp is deprecated in newer version of Pytorch. This PR updates unsloth.py to reflect that. Fixes issue#2015
Motivation and Context
axolotl/src/axolotl/utils/gradient_checkpointing/unsloth.py:28: FutureWarning:torch.cuda.amp.custom_fwd(args...)is deprecated. Please usetorch.amp.custom_fwd(args..., device_type='cuda')instead. axolotl/src/axolotl/utils/gradient_checkpointing/unsloth.py:39: FutureWarning:torch.cuda.amp.custom_bwd(args...)is deprecated. Please usetorch.amp.custom_bwd(args..., device_type='cuda')instead. 10.10.10.2: @torch.cuda.amp.custom_bwdHow has this been tested?
manually imported unsloth and now there are no more warning of deprecation
Screenshots (if appropriate)
Types of changes
Social Handles (Optional)