-
-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pre-commit: black+flake8+pylint+mypy+isort+bandit #98
Conversation
e90a990
to
e53fd64
Compare
Make sure this PR is squashed or things will be messy |
Fixed in c97a31c |
I will rebase before squash merge when you have finished review or when you think it's proper. I don't want to break the branch since you may be testing on it now. |
result["labels"][current_len : current_len + input_len] = labels | ||
current_len += input_len | ||
|
||
return result, current_len |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I refactored this function out due to mypy. However, would this be a performance loss since we call this function, then return the result and overwrite previous result object?
Co-authored-by: Wing Lian <wing.lian@gmail.com>
629a544
to
25eeeeb
Compare
Tested that it can finetune openllama config to step 25. Please make sure to squash into 1 commit. |
Add pre-commit: black+flake8+pylint+mypy+isort+bandit
Closes #43