Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cargo dependencies #1272

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Update cargo dependencies #1272

merged 1 commit into from
Aug 6, 2024

Conversation

darkdragon-001
Copy link
Collaborator

@darkdragon-001 darkdragon-001 commented Jul 29, 2024 •
edited
Loading

Generated by running cargo update.

@darkdragon-001 darkdragon-001 requested a review from nanu-c July 29, 2024 20:38
@darkdragon-001 darkdragon-001 force-pushed the update-cargo-dependencies branch from 7c6b49c to a44f2c6 Compare July 29, 2024 20:51
@darkdragon-001 darkdragon-001 marked this pull request as draft July 29, 2024 21:06
@darkdragon-001
Copy link
Collaborator Author

Looks like more dependency upgrades are blocked by the ancient clickable rustc.

@darkdragon-001
Copy link
Collaborator Author

darkdragon-001 commented Jul 29, 2024 •
edited
Loading

More dependencies require a rustc newer than 1.72.1 which is available in the clickable image. Unfortunately, there no currently no way to run cargo update while respecting the maximum rustc version: rust-lang/cargo#9930.
Created issue to update Rust toolchain in clickable image: https://gitlab.com/clickable/clickable/-/issues/439.

@darkdragon-001 darkdragon-001 force-pushed the update-cargo-dependencies branch from 00cf8d1 to 72053fe Compare August 5, 2024 15:09
@darkdragon-001
Copy link
Collaborator Author

Issues have been resolved in #1279

@darkdragon-001 darkdragon-001 force-pushed the update-cargo-dependencies branch from 72053fe to 6e6b3bd Compare August 5, 2024 15:12
@darkdragon-001 darkdragon-001 marked this pull request as ready for review August 5, 2024 15:12
@darkdragon-001 darkdragon-001 force-pushed the update-cargo-dependencies branch from 6e6b3bd to 8ff9c93 Compare August 5, 2024 15:13
@darkdragon-001 darkdragon-001 force-pushed the update-cargo-dependencies branch from 9e38dbd to ac7a336 Compare August 6, 2024 09:28
@darkdragon-001 darkdragon-001 merged commit 8e1451b into axolotl-chat:main Aug 6, 2024
12 checks passed
@darkdragon-001 darkdragon-001 deleted the update-cargo-dependencies branch August 6, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanu-c nanu-c nanu-c approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darkdragon-001 @nanu-c