Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ONNX dependency to version prior to bug introduction #641

Merged
merged 1 commit into from
May 26, 2022

Conversation

mathieuboudreau
Copy link
Member

@mathieuboudreau mathieuboudreau commented May 26, 2022

Bug report on the dependency's page: protocolbuffers/protobuf#10051

@mathieuboudreau mathieuboudreau marked this pull request as draft May 26, 2022 13:47
@mathieuboudreau mathieuboudreau marked this pull request as ready for review May 26, 2022 13:55
@mathieuboudreau
Copy link
Member Author

Thanks for reporting this @Stoyan-I-A and for finding the solution @hermancollin! The tests looks like they're currently going to pass with this change.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2391019679

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.735%

Totals Coverage Status
Change from base Build 2234899010: 0.0%
Covered Lines: 961
Relevant Lines: 1083

💛 - Coveralls

@mathieuboudreau
Copy link
Member Author

The tests all pass, ready for your approval @hermancollin and/or @Stoyan-I-A

@mathieuboudreau mathieuboudreau merged commit 8b93ba4 into master May 26, 2022
@mathieuboudreau mathieuboudreau deleted the mb/onnx-dep-bug branch May 26, 2022 16:27
@mathieuboudreau mathieuboudreau added this to the v4.1.0 milestone Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants