Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧠 Logic: 🧱 implement json_prolog/2 #350

Merged
merged 20 commits into from
May 4, 2023
Merged

🧠 Logic: 🧱 implement json_prolog/2 #350

merged 20 commits into from
May 4, 2023

Conversation

bdeneux
Copy link
Contributor

@bdeneux bdeneux commented Apr 28, 2023

This PR implement #348.

I hope tests case will cover all needs and json specification.

⚠️ Limitation

On this implementation, decimal number is not handled now. It will be the part of another PR.

@bdeneux bdeneux changed the title Logic: implement json_prolog/2 🧠 Logic: 🧱 implement json_prolog/2 Apr 28, 2023
@bdeneux bdeneux linked an issue Apr 28, 2023 that may be closed by this pull request
3 tasks
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #350 (e41ea03) into main (9380f31) will increase coverage by 1.84%.
The diff coverage is 89.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #350      +/-   ##
==========================================
+ Coverage   59.98%   61.82%   +1.84%     
==========================================
  Files          58       59       +1     
  Lines        2374     2533     +159     
==========================================
+ Hits         1424     1566     +142     
- Misses        876      888      +12     
- Partials       74       79       +5     
Impacted Files Coverage Δ
x/logic/predicate/json.go 86.29% <86.29%> (ø)
x/logic/predicate/util.go 100.00% <100.00%> (ø)

@bdeneux bdeneux marked this pull request as ready for review May 2, 2023 13:31
@bdeneux bdeneux requested review from ccamel and amimart May 2, 2023 13:33
@bdeneux bdeneux self-assigned this May 2, 2023
Copy link
Member

@ccamel ccamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great. 🤩
Thanks.

Copy link
Member

@amimart amimart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great thanks!

@bdeneux bdeneux merged commit 1ab81d9 into main May 4, 2023
@bdeneux bdeneux deleted the feat/json_prolog branch May 4, 2023 12:30
@bot-anik
Copy link
Member

🎉 This PR is included in version 5.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🧠 Logic: 🧱 json_prolog, add predicate to convert json to prolog terms
4 participants