Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧠 Logic: ⛓️ Implement read_string/3 predicate #381

Merged
merged 9 commits into from
Jun 23, 2023
Merged

🧠 Logic: ⛓️ Implement read_string/3 predicate #381

merged 9 commits into from
Jun 23, 2023

Conversation

bdeneux
Copy link
Contributor

@bdeneux bdeneux commented Jun 14, 2023 •
edited
Loading

Implement #380

@bdeneux bdeneux linked an issue Jun 15, 2023 that may be closed by this pull request
🧠 Logic: ⛓️ read_string/3 unify a stream to a string #380
Closed
3 tasks
@codecov
Copy link

codecov bot commented Jun 15, 2023 •
edited
Loading

Codecov Report

Merging #381 (aee8b8b) into main (35f02cf) will increase coverage by 0.23%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #381      +/-   ##
==========================================
+ Coverage   63.84%   64.07%   +0.23%     
==========================================
  Files          60       61       +1     
  Lines        2633     2661      +28     
==========================================
+ Hits         1681     1705      +24     
- Misses        873      876       +3     
- Partials       79       80       +1
Impacted Files Coverage Δ
x/logic/predicate/string.go 85.71% <85.71%> (ø)

@bdeneux bdeneux requested review from amimart and ccamel and removed request for amimart June 15, 2023 10:49
@bdeneux bdeneux self-assigned this Jun 15, 2023
@bdeneux bdeneux requested a review from amimart June 15, 2023 11:01
@bdeneux bdeneux marked this pull request as ready for review June 15, 2023 14:49
amimart
amimart requested changes Jun 19, 2023
View reviewed changes
Copy link
Member

@amimart amimart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks good to me :)

I just pointed out some grammatical mistakes in error messages, I've suggested some correction rephrasing messages, I'll let it to your appreciation :)

x/logic/predicate/string.go Outdated Show resolved Hide resolved
x/logic/predicate/string.go Outdated Show resolved Hide resolved
x/logic/predicate/string.go Outdated Show resolved Hide resolved
amimart
amimart approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@amimart amimart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

ccamel
ccamel approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@ccamel ccamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks 👍

@bdeneux bdeneux merged commit d931d67 into main Jun 23, 2023
18 checks passed
@bdeneux bdeneux deleted the feat/read_string branch June 23, 2023 12:36
@bot-anik
Copy link
Member

🎉 This PR is included in version 5.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccamel ccamel ccamel approved these changes

@amimart amimart amimart approved these changes

Assignees

@bdeneux bdeneux

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🧠 Logic: ⛓️ read_string/3 unify a stream to a string
4 participants
@bdeneux @bot-anik @ccamel @amimart