-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧠 Logic: open/4
predicate
#393
Conversation
Codecov Report
@@ Coverage Diff @@
## main #393 +/- ##
==========================================
+ Coverage 64.53% 64.86% +0.33%
==========================================
Files 61 61
Lines 2653 2701 +48
==========================================
+ Hits 1712 1752 +40
- Misses 862 870 +8
Partials 79 79
|
80f32fd
to
b8275da
Compare
b8275da
to
a5ef9ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice piece thanks, I just suggested some corrections on error messages :)
Co-authored-by: Arnaud Mimart <33665250+amimart@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
🎉 This PR is included in version 5.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Implement our own
open/4
predicate, allowing usage of the virtual file system to open wasm uri which was not used in the ichiban implementation.See #379 for more details.