Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧠 Logic: open/4 predicate #393

Merged
merged 6 commits into from
Jun 24, 2023
Merged

🧠 Logic: open/4 predicate #393

merged 6 commits into from
Jun 24, 2023

Conversation

bdeneux
Copy link
Contributor

@bdeneux bdeneux commented Jun 20, 2023

Implement our own open/4 predicate, allowing usage of the virtual file system to open wasm uri which was not used in the ichiban implementation.
See #379 for more details.

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #393 (c2060ff) into main (abea475) will increase coverage by 0.33%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #393      +/-   ##
==========================================
+ Coverage   64.53%   64.86%   +0.33%     
==========================================
  Files          61       61              
  Lines        2653     2701      +48     
==========================================
+ Hits         1712     1752      +40     
- Misses        862      870       +8     
  Partials       79       79              
Impacted Files Coverage Δ
x/logic/predicate/file.go 92.07% <83.33%> (-7.93%) ⬇️

@bdeneux bdeneux linked an issue Jun 20, 2023 that may be closed by this pull request
@bdeneux bdeneux force-pushed the fix/open_predicate branch 3 times, most recently from 80f32fd to b8275da Compare June 23, 2023 09:27
@bdeneux bdeneux marked this pull request as ready for review June 23, 2023 13:56
@bdeneux bdeneux requested review from amimart and ccamel and removed request for amimart June 23, 2023 13:56
@bdeneux bdeneux self-assigned this Jun 23, 2023
Copy link
Member

@amimart amimart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice piece thanks, I just suggested some corrections on error messages :)

x/logic/predicate/file.go Outdated Show resolved Hide resolved
x/logic/predicate/file.go Outdated Show resolved Hide resolved
x/logic/predicate/file.go Outdated Show resolved Hide resolved
x/logic/predicate/file.go Outdated Show resolved Hide resolved
ccamel and others added 2 commits June 24, 2023 17:26
Co-authored-by: Arnaud Mimart <33665250+amimart@users.noreply.github.com>
Copy link
Member

@ccamel ccamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ccamel ccamel requested a review from amimart June 24, 2023 15:52
@ccamel ccamel merged commit 4f2b668 into main Jun 24, 2023
18 checks passed
@ccamel ccamel deleted the fix/open_predicate branch June 24, 2023 16:56
@bot-anik
Copy link
Member

🎉 This PR is included in version 5.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🧠 open/4 predicate not based of virtual FS
4 participants