Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(lint): prevent golangci cache issues #394

Merged
merged 1 commit into from
Jun 20, 2023
Merged

ci(lint): prevent golangci cache issues #394

merged 1 commit into from
Jun 20, 2023

Conversation

amimart
Copy link
Member

@amimart amimart commented Jun 20, 2023

The golangci-lint-action seems to encounter cache issues sometimes, see: https://github.com/okp4/okp4d/actions/runs/5320225585/jobs/9636440668

This is related to this issue: golangci/golangci-lint-action#135

It seems that disabling the setup-go action cache solves that, it shouldn't be problematic as the golangci action has its own cache.

@amimart amimart requested review from ccamel and bdeneux June 20, 2023 10:35
@amimart amimart self-assigned this Jun 20, 2023
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #394 (aad4d6c) into main (8825211) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #394   +/-   ##
=======================================
  Coverage   63.84%   63.84%           
=======================================
  Files          60       60           
  Lines        2633     2633           
=======================================
  Hits         1681     1681           
  Misses        873      873           
  Partials       79       79           

Copy link
Member

@ccamel ccamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oki 😌

Copy link
Contributor

@bdeneux bdeneux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@amimart amimart merged commit bd6c780 into main Jun 20, 2023
18 checks passed
@amimart amimart deleted the ci/fix-golang-ci branch June 20, 2023 13:37
@bot-anik
Copy link
Member

🎉 This PR is included in version 5.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants