Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug: fix the go linter issue by updating golangci-lint #397

Merged
merged 3 commits into from
Jun 23, 2023

Conversation

bdeneux
Copy link
Contributor

@bdeneux bdeneux commented Jun 23, 2023

Since go has been updated to 1.20, we need to update also Golangci-lint since GitHub action no longer returned error of lint.

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #397 (1ea3237) into main (d931d67) will increase coverage by 0.36%.
The diff coverage is 30.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #397      +/-   ##
==========================================
+ Coverage   64.16%   64.53%   +0.36%     
==========================================
  Files          61       61              
  Lines        2668     2653      -15     
==========================================
  Hits         1712     1712              
+ Misses        876      862      -14     
+ Partials       80       79       -1     
Impacted Files Coverage Δ
x/logic/types/codec.go 38.46% <0.00%> (ø)
x/logic/types/msg.go 0.00% <0.00%> (ø)
x/mint/module.go 0.00% <0.00%> (ø)
x/mint/types/msg.go 0.00% <0.00%> (ø)
x/mint/types/params.go 11.32% <0.00%> (+1.15%) ⬆️
x/vesting/module.go 0.00% <0.00%> (ø)
x/logic/fs/wasm.go 89.13% <100.00%> (ø)
x/logic/types/params.go 93.87% <100.00%> (+2.78%) ⬆️
x/mint/simulation/genesis.go 93.33% <100.00%> (ø)
x/vesting/types/vesting_account.go 69.00% <100.00%> (ø)

@bdeneux bdeneux marked this pull request as ready for review June 23, 2023 12:48
@bdeneux bdeneux requested review from ccamel and amimart June 23, 2023 12:49
@bdeneux bdeneux changed the title style(lint): remove all new linter issues 🐛 Bug: fix the go linter issue by updating golangci-lint Jun 23, 2023
Copy link
Member

@amimart amimart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 👌

Copy link
Member

@ccamel ccamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You never stop! Impressive! 😄

@bdeneux bdeneux merged commit abea475 into main Jun 23, 2023
@bdeneux bdeneux deleted the fix/golangci-lint branch June 23, 2023 13:51
@bot-anik
Copy link
Member

🎉 This PR is included in version 5.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants