Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/empty array #399

Merged
merged 3 commits into from
Jun 27, 2023
Merged

Fix/empty array #399

merged 3 commits into from
Jun 27, 2023

Conversation

ccamel
Copy link
Member

@ccamel ccamel commented Jun 25, 2023 •
edited
Loading

Fix #398.

@ccamel ccamel self-assigned this Jun 25, 2023
@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Merging #399 (b530cfa) into main (1ea3237) will increase coverage by 0.41%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #399      +/-   ##
==========================================
+ Coverage   64.53%   64.94%   +0.41%     
==========================================
  Files          61       62       +1     
  Lines        2653     2707      +54     
==========================================
+ Hits         1712     1758      +46     
- Misses        862      870       +8     
  Partials       79       79
Impacted Files Coverage Δ
x/logic/predicate/util.go 100.00% <ø> (ø)
x/logic/predicate/atom.go 100.00% <100.00%> (ø)
x/logic/predicate/json.go 86.82% <100.00%> (+0.53%) ⬆️

... and 1 file with indirect coverage changes

@ccamel ccamel requested review from amimart and bdeneux June 25, 2023 08:51
@ccamel ccamel marked this pull request as ready for review June 25, 2023 08:51
bdeneux
bdeneux approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@bdeneux bdeneux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! 👍 Thanks 😁

amimart
amimart approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@amimart amimart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ccamel ccamel merged commit 2efb9eb into main Jun 27, 2023
18 checks passed
@ccamel ccamel deleted the fix/empty-array branch June 27, 2023 06:37
@bot-anik
Copy link
Member

🎉 This PR is included in version 5.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amimart amimart amimart approved these changes

@bdeneux bdeneux bdeneux approved these changes

Assignees

@ccamel ccamel

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🧠 Logic: json_prolog array serialization issue
4 participants
@ccamel @bot-anik @amimart @bdeneux