Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧬 Buf: don't draft on main #409

Merged
merged 1 commit into from
Jun 30, 2023
Merged

🧬 Buf: don't draft on main #409

merged 1 commit into from
Jun 30, 2023

Conversation

bdeneux
Copy link
Contributor

@bdeneux bdeneux commented Jun 30, 2023

Sorry for the second PR following #408, draft is not allowed on main branch (since main name isn't allowed by buf registry). Put back like is done on the buf-push-action except that in case of a tag, we put the tag name instead of the commit SHA.

@bdeneux bdeneux marked this pull request as ready for review June 30, 2023 14:26
@bdeneux bdeneux self-assigned this Jun 30, 2023
Copy link
Member

@amimart amimart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay seems good! :)

@bdeneux bdeneux requested a review from ccamel June 30, 2023 14:30
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #409 (758e0ee) into main (591c0dd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #409   +/-   ##
=======================================
  Coverage   64.94%   64.94%           
=======================================
  Files          62       62           
  Lines        2707     2707           
=======================================
  Hits         1758     1758           
  Misses        870      870           
  Partials       79       79           

Copy link
Member

@ccamel ccamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bdeneux bdeneux merged commit e2bb593 into main Jun 30, 2023
@bdeneux bdeneux deleted the fix/buf-draft branch June 30, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants