Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Starship integration #420

Merged
merged 9 commits into from
Aug 23, 2023
Merged

Starship integration #420

merged 9 commits into from
Aug 23, 2023

Conversation

Anmol1696
Copy link
Contributor

  • Run 2 chain starship client
  • Run ci tests

@codecov
Copy link

codecov bot commented Jul 16, 2023 •
edited
Loading

Codecov Report

Merging #420 (69b4ea6) into main (70fce53) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #420   +/-   ##
=======================================
  Coverage   64.94%   64.94%           
=======================================
  Files          62       62           
  Lines        2707     2707           
=======================================
  Hits         1758     1758           
  Misses        870      870           
  Partials       79       79

@ccamel ccamel assigned ccamel, amimart and bdeneux and unassigned bdeneux Jul 16, 2023
@Anmol1696 Anmol1696 changed the title Starship integration WIP: Starship integration Jul 16, 2023
@ccamel ccamel marked this pull request as draft July 16, 2023 10:57
@ccamel ccamel changed the title WIP: Starship integration Starship integration Aug 20, 2023
@ccamel ccamel marked this pull request as ready for review August 22, 2023 11:49
ccamel
ccamel approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@ccamel ccamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks ❤️

bdeneux
bdeneux approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@bdeneux bdeneux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good ! Nice 👍

@ccamel
Copy link
Member

ccamel commented Aug 23, 2023

@bdeneux I propose to merge it. When @amimart returns, we'll see what improvements and evolutions we can make on this. 😌

@ccamel ccamel merged commit c5ddb85 into axone-protocol:main Aug 23, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccamel ccamel ccamel approved these changes

@bdeneux bdeneux bdeneux approved these changes

@amimart amimart Awaiting requested review from amimart

Assignees

@ccamel ccamel

@amimart amimart

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Anmol1696 @ccamel @bdeneux @amimart