Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ chore: bump ibc-go from v8.0.0 to v8.2.1 #664

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Conversation

bdeneux
Copy link
Contributor

@bdeneux bdeneux commented May 30, 2024

This PR updates the ibc-go dependency from version 8.0.0 to 8.2.1.

The main reason for this update is to address the vulnerability ASA-2024-007: Potential Reentrancy using Timeout Callbacks in ibc-hooks as detailed in the security advisory.

Please note that we are not updating to the latest version 8.3.1 due to an issue that occurs when trying to launch the blockchain. More details about this issue can be found in the Dependabot PR results and the related CosmWasm PR.

🔗 Related issue : #635

Summary by CodeRabbit

  • Chores
    • Updated import statements to improve code quality and maintainability.

Copy link
Contributor

coderabbitai bot commented May 30, 2024

Walkthrough

The import statement for ibcclienttypes in the app/app.go file has been updated to remove the //nolint:staticcheck directive. This change ensures that static analysis tools will now check this import for any potential issues, enhancing code quality and maintainability.

Changes

File Change Summary
app/app.go Removed //nolint:staticcheck directive from the import statement for ibcclienttypes

Poem

In the code where imports gleam,
A linting rule now joins the team,
No more nolint to ignore,
Static checks will scan once more.
Cleaner code and better sight,
Let the linter's light shine bright!
🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@bdeneux bdeneux linked an issue May 30, 2024 that may be closed by this pull request
@bdeneux bdeneux changed the title ⬆️ Chore/bump ibc go ⬆️ chore: bump ibc-go from v8.0.0 to v8.2.1 May 30, 2024
@bdeneux bdeneux force-pushed the chore/bump-ibc-go branch from 9513298 to 00f9e95 Compare May 30, 2024 14:24
@bdeneux bdeneux marked this pull request as ready for review May 30, 2024 14:27
@bdeneux bdeneux requested review from amimart and ccamel May 30, 2024 14:29
@bdeneux bdeneux self-assigned this May 30, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 03c53a8 and 00f9e95.

Files ignored due to path filters (10)
  • docs/command/axoned_query_ibc_channel.md is excluded by !docs/command/**/*.md
  • docs/command/axoned_query_ibc_channel_params.md is excluded by !docs/command/**/*.md
  • docs/command/axoned_query_ibc_channel_upgrade-error.md is excluded by !docs/command/**/*.md
  • docs/command/axoned_query_ibc_channel_upgrade.md is excluded by !docs/command/**/*.md
  • docs/command/axoned_tx_ibc_channel.md is excluded by !docs/command/**/*.md
  • docs/command/axoned_tx_ibc_channel_prune-acknowledgements.md is excluded by !docs/command/**/*.md
  • docs/command/axoned_tx_ibc_channel_upgrade-channels.md is excluded by !docs/command/**/*.md
  • docs/command/axoned_tx_interchain-accounts_controller_register.md is excluded by !docs/command/**/*.md
  • go.mod is excluded by !**/*.mod
  • go.sum is excluded by !**/*.sum
Files selected for processing (1)
  • app/app.go (1 hunks)
Files skipped from review due to trivial changes (1)
  • app/app.go

Copy link
Member

@ccamel ccamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 👍

@bdeneux
Copy link
Contributor Author

bdeneux commented May 31, 2024

New issue to follow that correspond to issue encountered when starting chain with version 8.3.1 : cosmos/ibc-go#6435

Copy link
Member

@amimart amimart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to me 👍

@bdeneux bdeneux merged commit 4fd603e into main Jun 4, 2024
19 checks passed
@bdeneux bdeneux deleted the chore/bump-ibc-go branch June 4, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🛡️ Potential Reentrancy using Timeout Callbacks
3 participants