Feat/bump wasm 0.52.0 #702
Conversation
WalkthroughThis update enhances the application by upgrading dependencies, refining the IBC module for better fee management, and introducing a new function to clean the protobuf registry. The Dockerfile reflects updates to library versions, ensuring the latest features and fixes are included. Overall, these changes improve stability, performance, and maintainability, while promoting a more event-driven architecture within the application. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Command
participant ProtoRegistry
participant IBCModule
participant FeeModule
User->>Command: Initialize Command
Command->>ProtoRegistry: Sanitize Registry
ProtoRegistry-->>Command: Cleaned Registry
Command->>IBCModule: Setup IBC Module
IBCModule->>FeeModule: Initialize Fee Management
FeeModule-->>IBCModule: Ready for Operations
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #702 +/- ##
=======================================
Coverage 54.23% 54.23%
=======================================
Files 74 74
Lines 2906 2906
=======================================
Hits 1576 1576
Misses 1234 1234
Partials 96 96 |
This is consensus breaking so consider this change as breaking change.
amimart
force-pushed
the
feat/bump-wasm-0.52.0
branch
2 times, most recently
from
d2d4bc0
to
b962828
Compare
amimart
force-pushed
the
feat/bump-wasm-0.52.0
branch
from
b962828
to
7d2c9d9
Compare
amimart
force-pushed
the
feat/bump-wasm-0.52.0
branch
from
7d2c9d9
to
afbb710
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (2)
docs/command/axoned_tx_interchain-accounts_controller_register.mdis excluded by!docs/command/**/*.mdgo.sumis excluded by!**/*.sum
Files selected for processing (4)
- Dockerfile (1 hunks)
- app/app.go (9 hunks)
- cmd/axoned/cmd/root.go (3 hunks)
- go.mod (11 hunks)
Additional comments not posted (22)
Dockerfile (2)
13-14: Ensure SHA256 checksums are correct.The SHA256 checksums must match the expected values for the downloaded files. Verification is required.
7-8: Verify the updated URLs and checksums.Ensure that the URLs for the
libwasmvm_muslclibraries and their corresponding SHA256 checksums are correct and match the expected values for version 2.1.0.cmd/axoned/cmd/root.go (2)
15-16: New imports for protobuf registry.The new imports for
protoreflectandprotoregistryare necessary for thesanitizeProtoRegistryfunction.
55-56: InvokesanitizeProtoRegistryearly inNewRootCmd.The
sanitizeProtoRegistryfunction is invoked at the beginning ofNewRootCmdto ensure the protobuf registry is cleaned up before any other operations.go.mod (9)
20-20: Updatecosmossdk.io/x/upgradeto v0.1.3.The update from v0.1.2 to v0.1.3 likely includes minor bug fixes or enhancements. Ensure compatibility with the rest of the codebase.
22-22: Updategit.luolix.top/CosmWasm/wasmdto v0.52.0.The update from v0.51.0 to v0.52.0 introduces new features and improvements. Ensure compatibility with the rest of the codebase.
31-31: Updategit.luolix.top/cosmos/ibc-go/v8to v8.3.2.The update from v8.2.1 to v8.3.2 likely includes important changes. Ensure compatibility with the rest of the codebase.
46-46: Updategit.luolix.top/piprate/json-goldto v0.5.1-0.20230111113000-6ddbe6e6f19f.The update from v0.5.0 to v0.5.1-0.20230111113000-6ddbe6e6f19f likely includes bug fixes or improvements. Ensure compatibility with the rest of the codebase.
59-59: Updategoogle.golang.org/genproto/googleapis/apito v0.0.0-20240311132316-a219d84964c2.The update reflects a change in the versioning scheme. Ensure compatibility with the rest of the codebase.
81-81: Updatecloud.google.com/goto v0.112.1.The update from v0.112.0 to v0.112.1 likely includes minor bug fixes or improvements. Ensure compatibility with the rest of the codebase.
148-148: Updategit.luolix.top/go-jose/go-jose/v3to v3.0.1.The update from v3.0.1-0.20221117193127-916db76e8214 to v3.0.1 likely includes bug fixes or improvements. Ensure compatibility with the rest of the codebase.
252-252: Updategit.luolix.top/rs/zerologto v1.33.0.The update from v1.32.0 to v1.33.0 likely includes bug fixes or improvements. Ensure compatibility with the rest of the codebase.
283-285: Updatego.opentelemetry.io/otelto v1.24.0.The update from v1.22.0 to v1.24.0 likely includes new features, bug fixes, or improvements. Ensure compatibility with the rest of the codebase.
app/app.go (9)
111-111: Import ofibccallbackspackage approved.The addition of the
ibccallbackspackage is noted and aligns with the introduction of callback mechanisms in the IBC logic.
494-495: Creation of IBC Keeper approved.The initialization of the IBC Keeper is crucial for handling IBC operations and aligns with the changes introduced.
506-514: Introduction of IBC Fee Module keeper approved.The initialization of the IBC Fee Module keeper is essential for managing transaction fees associated with IBC operations.
542-543: Setting gRPC router for ICA Host approved.The setting of the gRPC router for the ICA Host is necessary for handling interchain account operations.
610-612: Initialization of Wasm Keeper with built-in capabilities approved.The initialization of the Wasm Keeper with built-in capabilities is crucial for managing Wasm modules.
615-618: Creation of fee-enabled Wasm IBC stack approved.The creation of the fee-enabled Wasm IBC stack is essential for handling IBC operations with fee management.
624-636: Creation of Interchain Accounts Stack with middleware approved.The creation of the Interchain Accounts Stack with middleware enhances the modularity and control flow of interchain account operations.
640-641: Passing ICS4Wrapper to ICA Controller Keeper approved.Passing the ICS4Wrapper to the ICA Controller Keeper is necessary for handling interchain account operations.
649-656: Creation of Transfer Stack with middleware approved.The creation of the Transfer Stack with middleware enhances the modularity and control flow of transfer operations.
Upgrade the
wasmmodule to its latest version v0.52.0 shipping the latestwasmvmv2.1.0 bringing new IBC entrypoints.Note: This change is consensus breaking
Misc
The new safe query mechanism (i.e. automatically register queries that are safe to use through IBC) enters in conflicts with protos brought by the hyperledger library (i.e.
google.crypto.tink). As we don't rely on them I've decided to remove them from the proto global registry when creating the root cmd.Summary by CodeRabbit
New Features
Bug Fixes
Chores