feat(logic): mark rpc queries as safe

[amimart]

Allow to use logic module queries from ICA module safe query by marking them as safe.

Summary by CodeRabbit

• New Features
  • Enhanced integration with the Cosmos SDK's query functionality for improved interoperability.
  • Added safety options to the Params and Ask queries within the QueryService to ensure safer execution in the Cosmos module context.

These changes elevate the operational safety and compatibility of the query service within the broader Cosmos framework.

[coderabbitai]

Walkthrough

The recent changes enhance the query.proto file in the logic.v1beta2 package by integrating with the Cosmos SDK's query capabilities. Key updates include a new import statement and modifications to the Params and Ask RPCs, marking them as safe for module queries. These improvements aim to bolster the safety and interoperability of the QueryService within the Cosmos framework, ensuring reliable operations without side effects.

Changes

File	Change Summary
proto/logic/v1beta2/query.proto	Added import for "cosmos/query/v1/query.proto". Updated Params and Ask RPCs to include option (cosmos.query.v1.module_query_safe) = true;.

Poem

In the meadow where queries play,
A safe path now lights the way.
With Cosmos' whispers, we take our stand,
Making sure all queries are grand!
Hooray for the changes, let joy reside,
In our hopping hearts, let safety guide! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

@@           Coverage Diff           @@
##             main     #711   +/-   ##
=======================================
  Coverage   54.42%   54.42%           
=======================================
  Files          73       73           
  Lines        2901     2901           
=======================================
  Hits         1579     1579           
  Misses       1228     1228           
  Partials       94       94           

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 963f560 and 66b1b8c.

Files ignored due to path filters (1)

• x/logic/types/query.pb.go is excluded by !**/*.pb.go

Files selected for processing (1)

• proto/logic/v1beta2/query.proto (2 hunks)

Additional comments not posted (3)

proto/logic/v1beta2/query.proto (3)

5-5: Import statement looks good.

The import of cosmos/query/v1/query.proto is necessary for the module_query_safe option.

---

17-17: Marking Params RPC as safe is correct.

The option (cosmos.query.v1.module_query_safe) = true; correctly marks the Params RPC as safe.

---

25-25: Marking Ask RPC as safe is correct.

The option (cosmos.query.v1.module_query_safe) = true; correctly marks the Ask RPC as safe.

[ccamel]

Good improvement. 👍

[bdeneux]

👍