-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: simplify readme #715
Conversation
Warning Rate limit exceeded@amimart has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 45 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe recent changes to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
803a2bc
to
2a3a014
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #715 +/- ##
==========================================
+ Coverage 54.42% 54.49% +0.06%
==========================================
Files 73 73
Lines 2901 2905 +4
==========================================
+ Hits 1579 1583 +4
Misses 1228 1228
Partials 94 94 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- README.md (1 hunks)
Additional comments not posted (5)
README.md (5)
62-79
: Simplified installation instructions look good!The new installation instructions are clear and concise. The methods "From release", "From source", and "Using docker" are well-documented.
70-73
: Building from source instructions look good!The
make install
command is appropriate for building from source and is correctly documented.
76-79
: Docker usage instructions look good!The
docker run
command is appropriate and correctly documented.
62-79
: Overall structure of the "Install" section is clear and concise.The simplified "Install" section enhances clarity and ease of use, focusing on essential commands.
64-67
: Verify the safety of thecurl
command.Using
curl
to download and execute a script can be risky. Ensure the script is from a trusted source and consider adding a checksum verification step.
2a3a014
to
caaca26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I propose some enhancements in the
README.md
by removing documentation related to the usage with the docker image as it is outdated and already covered elsewhere.To enhance developper experience I propose to enhance the contributing section mentioning how to run a local network.
Summary by CodeRabbit
axoned
project.curl
command for ease of use.