Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/deps security #732

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Fix/deps security #732

merged 3 commits into from
Aug 28, 2024

Conversation

amimart
Copy link
Member

@amimart amimart commented Aug 28, 2024

This PR bump some versions to solve security issues.

Details

wasmd is bumped to v0.53.0 in order to fix CWA-2024-005 & CWA-2024-006.
This also include a bump of cosmos-sdk to v0.50.9.

In order to fix CWA-2024-004 issue the wasmvm included in the docker build has also been updated to v2.1.3.

⚠️ Those changes are consensus breaking so it'll be considered as a major version update.

Summary by CodeRabbit

  • New Features

    • Updated libraries to enhance stability and performance, including the addition of a new dependency that may enable new functionality.
  • Bug Fixes

    • Upgraded various dependencies to incorporate important bug fixes and improvements.
  • Chores

    • Updated Docker image libraries for better compatibility and security.

This brings security fixes for CWA-2024-005 & CWA-2024-005.
This also induce a cosmos-sdk upgrade to v0.50.9
Include security fix for CWA-2024-004.
@amimart amimart self-assigned this Aug 28, 2024
Copy link
Contributor

coderabbitai bot commented Aug 28, 2024

Walkthrough

The recent changes involve updates to the Dockerfile and go.mod file. The Dockerfile reflects a version upgrade of the libwasmvm_muslc libraries from 2.1.0 to 2.1.2, with corresponding SHA256 checksum updates. The go.mod file sees multiple dependency version upgrades, including notable libraries like cosmossdk.io/core and github.com/prometheus/client_golang, as well as the addition of a new indirect dependency, github.com/munnerz/goautoneg.

Changes

Files Change Summary
Dockerfile Updated libwasmvm_muslc libraries from version 2.1.0 to 2.1.2 and updated corresponding SHA256 checksums.
go.mod Upgraded multiple dependencies, including cosmossdk.io/core to v0.11.1 and golang.org/x/crypto to v0.25.0. Added new indirect dependency github.com/munnerz/goautoneg.

Poem

🐇 In the garden where code blooms bright,
New versions hop, a joyful sight!
Libraries dance, in upgrades they play,
With checksums fresh, they brighten the day.
Let’s celebrate change, with a leap and a cheer,
For progress is sweet, and the future is near! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #732   +/-   ##
=======================================
  Coverage   54.49%   54.49%           
=======================================
  Files          73       73           
  Lines        2905     2905           
=======================================
  Hits         1583     1583           
  Misses       1228     1228           
  Partials       94       94           

@amimart amimart marked this pull request as ready for review August 28, 2024 08:01
@amimart amimart requested review from bdeneux and ccamel August 28, 2024 08:01
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9e4d760 and 824202f.

Files ignored due to path filters (8)
  • docs/command/axoned_config.md is excluded by !docs/command/**/*.md
  • docs/command/axoned_config_get.md is excluded by !docs/command/**/*.md
  • docs/command/axoned_config_home.md is excluded by !docs/command/**/*.md
  • docs/command/axoned_config_set.md is excluded by !docs/command/**/*.md
  • docs/command/axoned_config_view.md is excluded by !docs/command/**/*.md
  • docs/command/axoned_query_blocks.md is excluded by !docs/command/**/*.md
  • docs/command/axoned_tx_wasm_submit-proposal_instantiate-contract-2.md is excluded by !docs/command/**/*.md
  • go.sum is excluded by !**/*.sum
Files selected for processing (2)
  • Dockerfile (1 hunks)
  • go.mod (9 hunks)
Files skipped from review due to trivial changes (2)
  • Dockerfile
  • go.mod

Copy link
Member

@ccamel ccamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👌

Copy link
Contributor

@bdeneux bdeneux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@amimart amimart merged commit 94d9e8d into main Aug 28, 2024
20 checks passed
@amimart amimart deleted the fix/deps-security branch August 28, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants