Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(docker): relax apk version constraint for git #752

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

ccamel
Copy link
Member

@ccamel ccamel commented Sep 17, 2024

Update the Dockerfile to use a flexible version constraint when installing git via apk. Now uses the latest compatible version that matches the specified major and minor version.

This fixes the docker build issue reported by the CI.

image

Summary by CodeRabbit

Summary by CodeRabbit

  • Chores
    • Updated the package installation command for git to allow for flexible versioning within the 2.40 series, enhancing package management.

@ccamel ccamel self-assigned this Sep 17, 2024
Copy link
Contributor

coderabbitai bot commented Sep 17, 2024

Walkthrough

The changes involve a modification to the Dockerfile, specifically in the installation command for the git package using the Alpine package manager (apk). The original command specified a fixed version of git (2.40.1-r0), while the updated command employs a version constraint (git~2.40), allowing for the installation of any compatible version within the 2.40 series. Other components installed remain unchanged, including ca-certificates, build-base, and linux-headers.

Changes

File Change Summary
Dockerfile Updated git installation from a fixed version (2.40.1-r0) to a version constraint (git~2.40). Other installations remain unchanged.

Poem

In the land of code where rabbits play,
A change was made, hip-hip-hooray!
With git now free to hop and roam,
Versions can dance, find a new home.
So let’s celebrate with a joyful cheer,
For flexibility brings us all near! 🐇✨


Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4541aee and 723def8.

Files selected for processing (1)
  • Dockerfile (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • Dockerfile

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai generate interesting stats about this repository and render them as a table.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #752   +/-   ##
=======================================
  Coverage   54.49%   54.49%           
=======================================
  Files          73       73           
  Lines        2905     2905           
=======================================
  Hits         1583     1583           
  Misses       1228     1228           
  Partials       94       94           

@ccamel ccamel force-pushed the build/fix-git-version-in-docker branch from 086b21e to 4541aee Compare September 17, 2024 12:15
@ccamel ccamel marked this pull request as draft September 17, 2024 12:26
@ccamel ccamel force-pushed the build/fix-git-version-in-docker branch from 4541aee to 723def8 Compare September 17, 2024 12:29
@ccamel ccamel marked this pull request as ready for review September 17, 2024 12:56
Copy link
Contributor

@bdeneux bdeneux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@ccamel ccamel merged commit 1386794 into main Sep 17, 2024
20 checks passed
@ccamel ccamel deleted the build/fix-git-version-in-docker branch September 17, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants