Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/docs generation #311

Merged
merged 8 commits into from
Aug 17, 2023
Merged

Feat/docs generation #311

merged 8 commits into from
Aug 17, 2023

Conversation

bdeneux
Copy link
Contributor

@bdeneux bdeneux commented Aug 16, 2023

📚 New docs generation

Following the @egasimus PR, a new tool is used to generate contract's documentation to make it more readable.

This PR add fadroma/schema dependency into the makefile allowing generate new documentation and remove the old json2schema package.

@egasimus : FYI, when this PR will be merge, this new generated docs will be updated into the contracts folder of the docs repository. In the docs PR, you will need to update only the versioned_contract folders.

@bot-anik
Copy link
Member

bot-anik commented Aug 16, 2023

size-limit report 📦

Path Size
target/wasm32-unknown-unknown/release/okp4_objectarium.wasm 428.74 KB (0%)
target/wasm32-unknown-unknown/release/okp4_law_stone.wasm 635.72 KB (0%)
target/wasm32-unknown-unknown/release/okp4_cognitarium.wasm 758.43 KB (0%)

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #311 (2925ead) into main (a8cb7cf) will not change coverage.
Report is 6 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #311   +/-   ##
=======================================
  Coverage   98.00%   98.00%           
=======================================
  Files          41       41           
  Lines        8787     8787           
=======================================
  Hits         8612     8612           
  Misses        175      175           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bdeneux bdeneux marked this pull request as ready for review August 16, 2023 10:03
@bdeneux bdeneux requested review from amimart and ccamel August 16, 2023 10:03
@bdeneux bdeneux self-assigned this Aug 16, 2023
Copy link
Member

@ccamel ccamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting! 🎉 I'm eager to see the generated documentation on our Docusaurus website.

I've provided some feedback. The decision is yours! 🙏

Makefile.toml Outdated Show resolved Hide resolved
Makefile.toml Outdated Show resolved Hide resolved
Copy link
Member

@ccamel ccamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks so much.

Copy link
Contributor

@egasimus egasimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇‍♂️

@bdeneux bdeneux merged commit bf81c54 into main Aug 17, 2023
18 checks passed
@bdeneux bdeneux deleted the feat/docs-generation branch August 17, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants