-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏭 build: replace sleep
command by wait-tx
#568
Conversation
WalkthroughThe recent updates to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- Makefile.toml (4 hunks)
Additional comments not posted (4)
Makefile.toml (4)
436-440
: Replacesleep
withwait-tx
to ensure transaction completion before proceeding.This change aligns with the removal of the
--broadcast-mode block
option incosmos-sdk
and should enhance the reliability of the build process by ensuring that transactions are fully processed before moving on.
526-530
: Ensure proper transaction handling withwait-tx
in contract instantiation.This modification is crucial for ensuring that the contract instantiation does not proceed until the transaction is confirmed, which is particularly important in automated scripts to prevent race conditions.
594-600
: Usewait-tx
for robust transaction handling in contract execution.Adopting
wait-tx
here is a proactive measure to handle potential delays or issues in transaction processing, ensuring that the script only proceeds once the transaction is fully acknowledged by the network.
660-660
: Update Docker image toaxoneprotocol/axoned:8.0.0
.Upgrading to the latest Docker image version is a good practice to take advantage of the latest features and security patches. Ensure that this version is compatible with all dependencies and the overall environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Much better this way 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes my conscious much more cleaner thanks! 🙏
Now we can sleep (for real) peacefully 🙃 |
Since the removing of
--broadcast-mode block
options oncosmos-sdk
, no equivalence was existing since thev0.50.6
. This version introduce<appd> query wait-tx
command to give the hash of the transaction to wait or get the STDIN to wait for the transaction registered in a block.This PR also set the latest version of axoneprotocol/axoned published in docker.
Summary by CodeRabbit
--broadcast-mode sync
with a new query command to wait on transactions.DOCKER_IMAGE_AXONED
to version8.0.0
.