Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style/tech doc #240

Merged
merged 5 commits into from
Jun 21, 2023
Merged

Style/tech doc #240

merged 5 commits into from
Jun 21, 2023

Conversation

ccamel
Copy link
Member

@ccamel ccamel commented Jun 20, 2023

This PR brings some minor changes:

  • rename the folder tech-doc into technical-documentation
  • improve sidebar configuration for the techical documenation (to make the content of the documentation visible in the sidebar)
  • fix css which was hidden the menu hierarchy in the sidebar preventing a correct display (see Make link orange #221)

Before:

image

After:

image

NB1: The current style is still not 100% correct, and there will be a need for further improvements, which can be addressed through additional PRs.
NB2: This fix is necessary for the writing of the technical part of the site.

Copy link
Contributor

@bdeneux bdeneux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ccamel ccamel marked this pull request as ready for review June 21, 2023 06:44
Copy link
Member

@MdechampG MdechampG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ccamel. Yes I will see with @ManonPoint26 all the modifications we need to do before creating a dedicated issue.

@ccamel ccamel merged commit 741c1bd into main Jun 21, 2023
@ccamel ccamel deleted the style/tech-doc branch June 21, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants