Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl web3 subscription #124

Merged
merged 1 commit into from
Feb 28, 2022
Merged

feat: impl web3 subscription #124

merged 1 commit into from
Feb 28, 2022

Conversation

driftluo
Copy link
Contributor

Which docs this PR relation:

impl web3 subscription

Which toolchain this PR adaption:

No Breaking Change

Special notes for your reviewer:

@codecov-commenter
Copy link

Codecov Report

Merging #124 (a6b4049) into main (03aade0) will decrease coverage by 0.78%.
The diff coverage is 0.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
- Coverage   38.17%   37.39%   -0.79%     
==========================================
  Files          77       78       +1     
  Lines        5234     5346     +112     
==========================================
+ Hits         1998     1999       +1     
- Misses       3236     3347     +111     
Impacted Files Coverage Δ
core/api/src/jsonrpc/impl.rs 0.00% <0.00%> (ø)
core/api/src/jsonrpc/mod.rs 0.00% <0.00%> (ø)
core/api/src/jsonrpc/web3_types.rs 0.00% <ø> (ø)
core/api/src/jsonrpc/ws_subscription.rs 0.00% <0.00%> (ø)
core/storage/src/lib.rs 59.85% <50.00%> (-0.07%) ⬇️

@driftluo driftluo merged commit cbc5b52 into main Feb 28, 2022
@driftluo driftluo deleted the impl-web3-subscription branch February 28, 2022 12:39
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants