refactor: more details for JSON RPC errors #1495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
CI tests run on commit:
CI test list:
Please check ci test results later. |
yangby-cryptape
requested review from
wenyuanhust and
Simon-Tl
and removed request for
wenyuanhust and
Simon-Tl
KaoImin
approved these changes
Oct 24, 2023
Flouse
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
This PR adds more details to JSON RPC errors.
Since the internal errors have no details, it's difficult to debug.
What is the impact of this PR?
No Breaking Change
CI Settings
CI Usage
Tip: Check the CI you want to run below, and then comment
/run-ci.CI Switch
CI Description