Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MimeKit package because of a security issue #43

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

axunonb
Copy link
Member

@axunonb axunonb commented Jul 16, 2024

PR Classification

This pull request focuses on code cleanup and modernization, specifically by enhancing test readability and consistency, adopting newer C# features, and updating dependencies.

PR Summary

The pull request modernizes the test suite and codebase of the MailMergeLib project by refactoring assertion syntax for better readability, adopting C# 8.0 nullable reference types, and updating NuGet package versions. Key changes include:

  • Refactored assertion syntax across multiple test classes to use Assert.That with the NUnit constraint model.
  • Introduced Assert.Multiple blocks in test methods for grouped assertion evaluation.
  • Updated method signatures to accept nullable reference types, reflecting adoption of C# 8.0 features.
  • Removed netcoreapp3.1 target framework and updated various NuGet package references in MailMergeLib.Tests.csproj.
  • Added NUnit.Analyzers reference in MailMergeLib.Tests.csproj for enhanced test writing assistance.

Package Updates

MailMergeLib package updates

  • MimeKit v4.6.0 => v4.7.1.1
  • MailKit v4.6.0 => 4.7.1
  • YAXLib v4.2.2 => v4.3.0

Unit test package updates

  • Microsoft.NET.Test.Sdk 17.6.3 => 17.10.0
  • NUnit v3.13.3 => v4.1.0
  • Drop NetCore3.1
  • Add Nunit.Analyzers v4.2.0

MailMergeLib package updates
* MimeKit v4.6.0 => v4.7.1.1
* MailKit v4.6.0 => 4.7.1
* YAXLib v4.2.2 => v4.3.0

Unit test package updates
* Microsoft.NET.Test.Sdk 17.6.3 => 17.10.0
* NUnit v3.13.3 => v4.1.0
* Drop NetCore3.1
* Add Nunit.Analyzers v4.2.0
@axunonb axunonb merged commit 5ad0f55 into main Jul 16, 2024
4 of 5 checks passed
@axunonb axunonb deleted the pr/mime-kit branch July 16, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant