x-pack/plugin/core: make automatic rollovers lazy

Apply automatic rollovers lazily, upon the next write, to avoid unnecessary empty backing indices. See elastic#89346
axw · Jan 22, 2024 · 0678f08 · 0678f08
1 parent 0bb87db
commit 0678f08
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/...lugin/core/src/main/java/org/elasticsearch/xpack/core/template/IndexTemplateRegistry.java b/...lugin/core/src/main/java/org/elasticsearch/xpack/core/template/IndexTemplateRegistry.java
@@ -814,6 +814,7 @@ public void onFailure(Exception e) {
                         templateName
                     );
                     RolloverRequest request = new RolloverRequest(rolloverTarget, null);
+                    request.lazy(true);
                     request.masterNodeTimeout(TimeValue.timeValueMinutes(1));
                     executeAsyncWithOrigin(
                         client.threadPool().getThreadContext(),

diff --git a/.../core/src/test/java/org/elasticsearch/xpack/core/template/IndexTemplateRegistryTests.java b/.../core/src/test/java/org/elasticsearch/xpack/core/template/IndexTemplateRegistryTests.java
@@ -377,6 +377,7 @@ public void testAutomaticRollover() throws Exception {
                 rolloverCounter.incrementAndGet();
                 RolloverRequest rolloverRequest = ((RolloverRequest) request);
                 assertThat(rolloverRequest.getRolloverTarget(), startsWith("logs-my_app-"));
+                assertThat(rolloverRequest.isLazy(), equalTo(true));
             } else if (action == TransportPutComposableIndexTemplateAction.TYPE) {
                 putIndexTemplateCounter.incrementAndGet();
             }