Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classes #1129

Merged
merged 36 commits into from
Jul 12, 2024
Merged

Classes #1129

merged 36 commits into from
Jul 12, 2024

Conversation

ice1000
Copy link
Member

@ice1000 ice1000 commented Jul 8, 2024

No description provided.

# Conflicts:
#	base/src/main/java/org/aya/tyck/ExprTycker.java
ice1000 added a commit that referenced this pull request Jul 8, 2024
Copy link
Member Author

@ice1000 ice1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: revise error messages

@ice1000 ice1000 added this to the v0.34 milestone Jul 12, 2024
Copy link
Contributor

@HoshinoTented HoshinoTented left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 69.09091% with 51 lines in your changes missing coverage. Please review.

Project coverage is 79.44%. Comparing base (f3a198a) to head (8f52aab).
Report is 1 commits behind head on main.

Files Patch % Lines
...se/src/main/java/org/aya/unify/TermComparator.java 27.27% 14 Missing and 2 partials ⚠️
...rc/main/java/org/aya/compiler/TermExprializer.java 66.66% 8 Missing ⚠️
...n/java/org/aya/syntax/core/term/ClassCastTerm.java 50.00% 3 Missing and 5 partials ⚠️
...java/org/aya/syntax/core/term/call/MemberCall.java 69.23% 1 Missing and 3 partials ⚠️
...in/java/org/aya/syntax/core/def/MemberDefLike.java 0.00% 3 Missing ⚠️
...rc/main/java/org/aya/syntax/core/term/NewTerm.java 57.14% 2 Missing and 1 partial ⚠️
base/src/main/java/org/aya/tyck/ExprTycker.java 92.00% 0 Missing and 2 partials ⚠️
base/src/main/java/org/aya/unify/Synthesizer.java 0.00% 2 Missing ⚠️
...e/src/main/java/org/aya/tyck/tycker/AppTycker.java 95.65% 0 Missing and 1 partial ⚠️
...ain/java/org/aya/cli/literate/SyntaxHighlight.java 87.50% 0 Missing and 1 partial ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1129      +/-   ##
============================================
+ Coverage     79.08%   79.44%   +0.35%     
- Complexity     3304     3361      +57     
============================================
  Files           302      306       +4     
  Lines         10064    10172     +108     
  Branches       1204     1228      +24     
============================================
+ Hits           7959     8081     +122     
+ Misses         1436     1411      -25     
- Partials        669      680      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ice1000 ice1000 merged commit 5cecead into main Jul 12, 2024
5 of 6 checks passed
@ice1000 ice1000 deleted the classes branch July 12, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants