Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hello, Aya Native. #388

Merged
merged 12 commits into from
Apr 23, 2022
Merged

Hello, Aya Native. #388

merged 12 commits into from
Apr 23, 2022

Conversation

imkiva
Copy link
Member

@imkiva imkiva commented Apr 17, 2022 •
edited
Loading

This PR integrates Aya with GraalVM's native image.

@codecov
Copy link

codecov bot commented Apr 17, 2022 •
edited
Loading

Codecov Report

Merging #388 (20991e9) into main (9a940f6) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #388   +/-   ##
=========================================
  Coverage     81.26%   81.26%           
  Complexity     2354     2354           
=========================================
  Files           216      216           
  Lines          7253     7253           
  Branches        862      862           
=========================================
  Hits           5894     5894           
  Misses          896      896           
  Partials        463      463

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74f84fb...20991e9. Read the comment docs.

ice1000
ice1000 reviewed Apr 17, 2022
View reviewed changes
Copy link
Member

@ice1000 ice1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

buildSrc/src/main/groovy/org/aya/gradle/GenerateReflectionConfigTask.groovy Outdated Show resolved Hide resolved
buildSrc/src/main/groovy/org/aya/gradle/GenerateReflectionConfigTask.groovy Outdated Show resolved Hide resolved
cli/build.gradle.kts Outdated Show resolved Hide resolved
imkiva
imkiva commented Apr 18, 2022
View reviewed changes
cli/build.gradle.kts Outdated Show resolved Hide resolved
@ice1000 ice1000 added this to the v0.18 milestone Apr 18, 2022
@ice1000 ice1000 added the build label Apr 18, 2022
@bors
Copy link
Contributor

bors bot commented Apr 18, 2022

✌️ imkiva can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

ice1000
ice1000 approved these changes Apr 18, 2022
View reviewed changes
Copy link
Member

@ice1000 ice1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d=imkiva

@imkiva imkiva force-pushed the strip-preview branch 4 times, most recently from 7448b86 to afc370a Compare April 18, 2022 10:26
@imkiva
Copy link
Member Author

imkiva commented Apr 18, 2022

https://www.graalvm.org/22.0/reference-manual/native-image/Agent/

@imkiva imkiva force-pushed the strip-preview branch 2 times, most recently from 9251343 to cc0711e Compare April 22, 2022 08:12
@imkiva
Copy link
Member Author

imkiva commented Apr 22, 2022

In case I forgot this url: https://repo.gradle.org/ui/native/jcenter/org/graalvm/buildtools/

@imkiva imkiva marked this pull request as ready for review April 22, 2022 08:55
@imkiva
Copy link
Member Author

imkiva commented Apr 22, 2022 •
edited
Loading

ONE LAST STEP: build native image in CI

This should be done in when-i-am-free branch and targeting this PR

@imkiva imkiva requested a review from ice1000 April 22, 2022 08:56
@imkiva imkiva changed the title [WIP] Generate native-image of cli module Hello, Aya Native. Apr 22, 2022
This was referenced Apr 22, 2022
Merged
Merged
bors bot added a commit that referenced this pull request Apr 22, 2022
@bors @imkiva
MERGE: #392
74f84fb 
392: Cherry pick r=imkiva a=imkiva

From #388 

Co-authored-by: imkiva <imkiva@islovely.icu>
imkiva and others added 6 commits April 22, 2022 19:01
@imkiva
BUILD: native-image of cli (step 1)
b9fb247 
This commit is squashed from the following commits:
REVIEW: address comments
BUILD: generate reflection config
BUILD: generate native image from cli
BUILD: strip preview feature bit from class file

Signed-off-by: imkiva <imkiva@islovely.icu>
@imkiva
BUILD: generate serialization-config.json
7582bc5 
Signed-off-by: imkiva <imkiva@islovely.icu>
@imkiva @lunalunaa
BUILD: apply @lunalunaa's suggestion
effeefb 
Co-authored-by: Luna <weitaoxin@gmail.com>
Signed-off-by: imkiva <imkiva@islovely.icu>
@imkiva
BUILD: update reflect-config.txt
0fbf174 
Signed-off-by: imkiva <imkiva@islovely.icu>
@imkiva
BUILD: strip preview on-the-fly
bd0acd6 
Signed-off-by: imkiva <imkiva@islovely.icu>
@imkiva
BUILD: support nativeTest
3334a91 
Signed-off-by: imkiva <imkiva@islovely.icu>
@imkiva
BUILD: generate config to META-INF/native-image
c656333 
Signed-off-by: imkiva <imkiva@islovely.icu>
@imkiva
BUILD: extract native binary config
2306d8c 
Signed-off-by: imkiva <imkiva@islovely.icu>
@imkiva
CI: try build native image
4c1bc84 
Signed-off-by: imkiva <imkiva@islovely.icu>
@ice1000
Copy link
Member

ice1000 commented Apr 22, 2022

Is it possible to configure the path of graalvm by gradle.properties?

@imkiva
Copy link
Member Author

imkiva commented Apr 22, 2022 •
edited
Loading

Related to the failure of Windows native image build: oracle/graal#4502

@imkiva
Copy link
Member Author

imkiva commented Apr 22, 2022

Is it possible to configure the path of graalvm by gradle.properties?

Did you mean the dependency in buildSrc?

@imkiva
Copy link
Member Author

imkiva commented Apr 22, 2022 •
edited
Loading

Is it possible to configure the path of graalvm by gradle.properties?

Oh sorry, I misunderstood you. Currently no. But you can set GRAALVM_HOME

@imkiva
CI: fix arch name
a6dbe09 
Signed-off-by: imkiva <imkiva@islovely.icu>
@imkiva
BUILD: no need to use fatJar
4faede4 
Signed-off-by: imkiva <imkiva@islovely.icu>
@imkiva
CI: fix windows native image build by downgrade GraalVM
20991e9 
Signed-off-by: imkiva <imkiva@islovely.icu>
ice1000
ice1000 approved these changes Apr 22, 2022
View reviewed changes
Copy link
Member

@ice1000 ice1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust your code.

@imkiva
Copy link
Member Author

imkiva commented Apr 23, 2022

I trust your code.

1

Thank you~ then I will
bors merge

@bors
Copy link
Contributor

bors bot commented Apr 23, 2022

Build succeeded:

@bors bors bot merged commit a0a1a6a into main Apr 23, 2022
@bors bors bot deleted the strip-preview branch April 23, 2022 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ice1000 ice1000 ice1000 approved these changes

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
v0.18
Development

Successfully merging this pull request may close these issues.
2 participants
@imkiva @ice1000