Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More robust parsing #876

Merged
merged 7 commits into from
Jan 6, 2023
Merged

More robust parsing #876

merged 7 commits into from
Jan 6, 2023

Conversation

ice1000
Copy link
Member

@ice1000 ice1000 commented Jan 6, 2023

Addresses a privately reported issue from @SchrodingerZhu
bors r+

@ice1000
Copy link
Member Author

ice1000 commented Jan 6, 2023

bors r-

@bors
Copy link
Contributor

bors bot commented Jan 6, 2023

Canceled.

@ice1000 ice1000 added this to the v0.27 milestone Jan 6, 2023
@ice1000 ice1000 added the parser label Jan 6, 2023
@ice1000 ice1000 marked this pull request as ready for review January 6, 2023 20:53
@ice1000
Copy link
Member Author

ice1000 commented Jan 6, 2023

bors r+

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Merging #876 (10596dc) into main (1ecad86) will decrease coverage by 0.01%.
The diff coverage is 83.01%.

@@             Coverage Diff              @@
##               main     #876      +/-   ##
============================================
- Coverage     82.15%   82.13%   -0.02%     
- Complexity     3374     3382       +8     
============================================
  Files           287      287              
  Lines         10500    10530      +30     
  Branches       1249     1257       +8     
============================================
+ Hits           8626     8649      +23     
- Misses         1166     1171       +5     
- Partials        708      710       +2     
Impacted Files Coverage Δ
base/src/main/java/org/aya/concrete/Expr.java 88.23% <ø> (ø)
...src/main/java/org/aya/cli/parse/AyaGKProducer.java 89.83% <82.00%> (-0.75%) ⬇️
...c/main/java/org/aya/concrete/error/ParseError.java 100.00% <100.00%> (ø)
.../src/main/java/org/aya/tyck/unify/Synthesizer.java 59.61% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bors
Copy link
Contributor

bors bot commented Jan 6, 2023

Build succeeded:

@bors bors bot merged commit b7aebc4 into main Jan 6, 2023
@bors bors bot deleted the parser branch January 6, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant