Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random refactoring, preparing for fixing Prop tycking #880

Merged
merged 4 commits into from
Jan 11, 2023
Merged

Random refactoring, preparing for fixing Prop tycking #880

merged 4 commits into from
Jan 11, 2023

Conversation

ice1000
Copy link
Member

@ice1000 ice1000 commented Jan 11, 2023

These commits have been in my disk for so long so I have made up my mind to create a PR for them

@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Merging #880 (8c64be2) into main (16daf93) will increase coverage by 0.07%.
The diff coverage is 52.94%.

@@             Coverage Diff              @@
##               main     #880      +/-   ##
============================================
+ Coverage     82.17%   82.24%   +0.07%     
- Complexity     3386     3388       +2     
============================================
  Files           288      288              
  Lines         10536    10528       -8     
  Branches       1258     1254       -4     
============================================
+ Hits           8658     8659       +1     
+ Misses         1166     1163       -3     
+ Partials        712      706       -6     
Impacted Files Coverage Δ
base/src/main/java/org/aya/core/term/PiTerm.java 70.17% <ø> (-1.76%) ⬇️
...ase/src/main/java/org/aya/core/term/SigmaTerm.java 84.78% <ø> (ø)
...src/main/java/org/aya/cli/parse/AyaGKProducer.java 89.83% <ø> (ø)
.../src/main/java/org/aya/tyck/tycker/PropTycker.java 64.28% <28.57%> (+17.22%) ⬆️
base/src/main/java/org/aya/tyck/ExprTycker.java 90.52% <57.14%> (+0.96%) ⬆️
base/src/main/java/org/aya/tyck/StmtTycker.java 90.27% <100.00%> (ø)
.../src/main/java/org/aya/tyck/unify/Synthesizer.java 61.53% <100.00%> (+1.92%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ice1000 ice1000 added this to the v0.27 milestone Jan 11, 2023
@ice1000
Copy link
Member Author

ice1000 commented Jan 11, 2023

bors r+

@ice1000 ice1000 marked this pull request as ready for review January 11, 2023 21:31
@bors
Copy link
Contributor

bors bot commented Jan 11, 2023

Build succeeded:

@bors bors bot merged commit 9ff759c into main Jan 11, 2023
@bors bors bot deleted the paxlovid branch January 11, 2023 21:33
@@ -148,7 +148,7 @@ record Tmp(ImmutableSeq<TeleResult> okTele, Term preresult, Term prebody) {}
var bodyExpr = fn.body.getLeftValue();
Term preresult, prebody;
if (fn.result != null) {
preresult = tycker.synthesize(fn.result).wellTyped();
preresult = tycker.ty(fn.result);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact the entire PR is just for this line ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant