-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
integration-test: Use veth pair instead of lo #915
Conversation
✅ Deploy Preview for aya-rs-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
80a87e3
to
5c69049
Compare
e342d15
to
d29ecc0
Compare
841ba92
to
3e2225c
Compare
Thanks for starting this @kevinji!! I'm going to start checking this out, Looks like we're still failing on macos though
|
Additionally you consider using dummy interfaces here rather than veth pairs? (as mentioned in #422) ? |
Ack just read that, sounds good thanks! |
3e2225c
to
f850be3
Compare
`netlink_add_veth_pair`, `netlink_delete_link`, `netlink_set_link_down`, and `netlink_add_ip_addr` are used in setting up and tearing down a veth pair for integration tests.
8ba5b71
to
a9a704e
Compare
a9a704e
to
7150c85
Compare
@astoycos I'm having trouble debugging the exact issue as I'm unable to get the QEMU setup working locally, so have been (slowly) trying to debug while pushing changes to CI. My current hypothesis is that since the integration tests run as the |
@kevinji, this pull request is now in conflict and requires a rebase. |
Fixes #422. I split the initial codegen commit out to #919 to clean this PR up.
I would like some help debugging the last 4 test failures:
I'm not sure if introducing the network namespace caused behavior to now be different.