-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install script abort when turn off shallow clone #674
Comments
i guess a lot of your programs are out-ot-date? maybe try update those programs first? (git for example) run: |
Also I suspect u didn't config your git -> github properly. did u choose |
Yes, I can confirm it before, but I forgot to report it. |
hmmm, but i never ran into this error, no matter I choose shallow clone for not. |
from the install.ps1, it's using https to clone this repo, maybe this cause some proxy issues? |
@FangLin2001 @ayamir can u check if directly cloning this repo via https works on windows with terminal proxies configed? |
side note: @Jint-lzxy i have an idea, can we live query the branch tags and let users decide which branch they want to install?1 curl -L https://api.github.com/repos/ayamir/nvimdots/branches | jq '.[].name' curl -L https://api.github.com/repos/ayamir/nvimdots/branches | grep name btw my Footnotes |
Nothing better after i update a particular WindowsSDK and i make sure my git works well. I can git fetch/clone any other repo.
It's OK to git clone https://github.com/ayamir/nvimdots.git in my device, btw i keep FastGithub running throughtout the installation. (https://github.com/dotnetcore/FastGithub) |
try this: |
🥺🥺🥺😭😭😭 |
Already tried and not works. But NodeJS dependency check have worked well and done in one of my attempts. |
I still think it's related to the GFW, since I never ran into errors like this. (based in Taiwan) But I often encounters errors while installing the nvim plugins, but I don't think it's related to the installation script. It's properly |
Although I still encounter npm UNABLE_TO_VERIFY_LEAF_SIGNATURE error in NodeJS dependencies check, as i have done it correctly somehow before, i ignore it and select Yes in git clone preference (still error with No). And most of things seems OK if ignoring errors generated by some plugins. Thanks a lot. |
Can reproduce under specific conditions (sometimes script blocks [used by As for the dependency installation issue, probably that is caused by accessing a source through a proxy and the proxy returned a corrupted (or empty) CA Certificate. Will look into this after the first issue is addressed. @FangLin2001 Will the following code block raise the same issue on your device? $env:CCLONE_ATTR = ''
try {
Invoke-Command -ErrorAction Stop -ScriptBlock { git clone --progress -b main "$env:CCLONE_ATTR" 'https://github.com/ayamir/nvimdots.git' }
if (-not $?) {
throw
}
}
catch {
Write-Error -Message "Command failed." -Category "InvalidResult"
} |
Hmm but I can't think of a reason why we should implement this - FWIW branch detection based on In fact, if ppl really want to customize their clone branch, Line 22 in f1c5f09
|
This is expected. Since you need to instruct |
I check your install.ps1, and obviously your test code block miss a param. In my point of view, the test code block should be like below, which is just like what you guys write in install.ps1. $env:CCLONE_ATTR = ''
$env:CCDEST_DIR ??= "$env:XDG_CONFIG_HOME\nvim"
try {
Invoke-Command -ErrorAction Stop -ScriptBlock { git clone --progress -b main "$env:CCLONE_ATTR" 'https://github.com/ayamir/nvimdots.git' "$env:CCDEST_DIR"}
if (-not $?) {
throw
}
}
catch {
Write-Error -Message "Command failed." -Category "InvalidResult"
} And in this case, run test.ps1 cause "fatal: Too many arguments.", which is just the same as what i got in my issue. Obviously the problem is that although $env:CCLONE_ATTR == "", "$env:CCLONE_ATTR" was wrongly treated as the first parameter. As a result, $env:CCLONE_ATTR = "" cause error and $env:CCLONE_ATTR = "--depth=1" is right. This problem is clear now. |
It's okay as this issue is not related to those subsequent commands, cloning to the current working directory is sufficient tho.
Great 👍 Many thanks for helping us with the testing. This is consistent with the results on macOS. |
Yes, that doesnt matter much, just error info differs: fatal: repository '' does not exist |
This is actually one thing, isn't it 😆 |
@FangLin2001 Quick fix: a26c878. You may need to wait for |
I'm forced to use --depth=1 to finish my installation already. So it helps others who want to turn off shallow clone. |
If you still wish a complete clone, you can remove the old installation first: Remove-Item -Recurse -Force "$env:LOCALAPPDATA\nvim"
Set-ExecutionPolicy Bypass -Scope Process -Force; Invoke-Expression ((New-Object System.Net.WebClient).DownloadString('https://raw.githubusercontent.com/ayamir/nvimdots/HEAD/scripts/install.ps1')) But partial cloning would suffice for non-development purposes 😄 |
@FangLin2001 Can you try setting However, do note that this method is not secure and is only used to test if the issue is caused by your proxy. Please unset this variable after confirmation: Also you need to explicitly specify your proxy:
|
cc @CharlesChiuGit in case u missed that :) |
@Jint-lzxy lol I had transfered it to #675 , since I think it's better not to start two conversation in one thread.🤣 |
You are right as npm install succeed if disabling certificate verification. |
I would suggest you contact ur proxy provider since we as users cannot do much to resolve this client-side issue. Closing as all the mentioned issues have been resolved. If u have any other related questions, feel free to reopen this at any time! |
Version confirmation
Following prerequisites
Neovim version
be set as backup by install script
Operating system/version
Win10 22H2 19045.2846
Terminal name/version
None
$TERM environment variable
No response
Branch info
main (Default/Latest)
Fetch Preferences
SSH (use_ssh = true)
How to reproduce the issue
Just run the install script in PowerShell 7
select No as 'git clone' preferences
Expected behavior
set 'git clone' preferences correctly
Actual behavior
_abort -Msg "Failed during: $WithCmd" -Type "InvalidResult"
Additional information
I encountered tons of errors when executing the install script, most of which disappeared after repeated execution and manual installation of dependencies.
The text was updated successfully, but these errors were encountered: