Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve user experience wrt transparent backgrounds #864

Closed
Jint-lzxy opened this issue Jul 14, 2023 · 0 comments · Fixed by #865
Closed

Improve user experience wrt transparent backgrounds #864

Jint-lzxy opened this issue Jul 14, 2023 · 0 comments · Fixed by #865
Labels
complexity:low Low-risk, unlikely to cause distant/indirect damage enhancement New feature or request ui General user interface related issues

Comments

@Jint-lzxy
Copy link
Collaborator

Jint-lzxy commented Jul 14, 2023

Feature description

This is part of #627 (UI update). The issue is if the user supplied non-zero values to pumblend (and winblend), several plugins' popup windows would be poorly configured - all having completely black backgrounds as "they have nothing to blend with" 🤣 The plan is to list all problematic plugins here and open a PR for this.

Additional information

List of related plugins:

NOTE: For plugins with asterisks (*) see below for an explanation.

Alternatives considered

We can also warn users who use transparent backgrounds not to change pumblend or winblend, rather than commenting them out. But plugins like nvim-notify and specs.nvim (with asterisks in their names) that use Normal (or other hl groups with no bg set) as their default highlight still need to be updated b/c otherwise they will use #000000 (fallback) as highlight.

Miscellaneous

At the same time, we can also update nvim[_buf|_win]_[gs]et_option API calls as AFAIK they're deprecated in NVIM v0.10.

@Jint-lzxy Jint-lzxy added enhancement New feature or request complexity:low Low-risk, unlikely to cause distant/indirect damage ui General user interface related issues labels Jul 14, 2023
Jint-lzxy added a commit that referenced this issue Jul 15, 2023
As per #864. Using the alternative method.
@Jint-lzxy Jint-lzxy linked a pull request Jul 15, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity:low Low-risk, unlikely to cause distant/indirect damage enhancement New feature or request ui General user interface related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant