Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ibl): support indent-blankline v3 #1011

Merged
merged 5 commits into from
Oct 1, 2023
Merged

Conversation

CharlesChiuGit
Copy link
Collaborator

@CharlesChiuGit CharlesChiuGit commented Sep 28, 2023

@CharlesChiuGit CharlesChiuGit changed the title migrate(idl): indent-blankline to v3 migrate(ibl): indent-blankline to v3 Sep 28, 2023
@CharlesChiuGit
Copy link
Collaborator Author

CharlesChiuGit commented Sep 28, 2023

there isn't an one-to-one mapping of the old config to the new one, so i tried my best to adapt the v3 config.

the colorschme and the detail settings might need further adjustments.

@CharlesChiuGit CharlesChiuGit marked this pull request as ready for review September 28, 2023 10:34
@Jint-lzxy Jint-lzxy changed the title migrate(ibl): indent-blankline to v3 feat(ibl): support indent-blankline v3 Sep 29, 2023
@Jint-lzxy
Copy link
Collaborator

115db05 updated several hl groups and added support for big files. It also mapped (almost) all v2 options to the corresponding valid entries in v3. The only exception here is ibl.config.scope.include: We presumably need more context/information (or upstream support) to make indent-blankline.scope work on all languages supported by Treesitter (lukas-reineke/indent-blankline.nvim#632)

Jint-lzxy added a commit that referenced this pull request Sep 29, 2023
Copy link
Collaborator Author

@CharlesChiuGit CharlesChiuGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

singlemancombat pushed a commit to singlemancombat/nvim-config that referenced this pull request Sep 30, 2023
Copy link
Owner

@ayamir ayamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayamir ayamir merged commit 8847a66 into main Oct 1, 2023
4 checks passed
@ayamir ayamir deleted the migrate/v3-indent-blankline branch October 1, 2023 10:03
@CharlesChiuGit CharlesChiuGit mentioned this pull request Oct 1, 2023
2 tasks
singlemancombat pushed a commit to singlemancombat/nvim-config that referenced this pull request Oct 1, 2023
* migrate(ibl): `indent-blankline` to v3

* migrate(ibl): draft v3 config

* feat(ibl): plugins support & misc updates

* fix merge conflicts

---------

Co-authored-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>
ttbug pushed a commit to ttbug/nvimconf that referenced this pull request Oct 7, 2023
* migrate(ibl): `indent-blankline` to v3

* migrate(ibl): draft v3 config

* feat(ibl): plugins support & misc updates

* fix merge conflicts

---------

Co-authored-by: Jint-lzxy <50296129+Jint-lzxy@users.noreply.github.com>
@CharlesChiuGit CharlesChiuGit mentioned this pull request Oct 11, 2023
3 tasks
This was referenced Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants