Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup and minor syntax improvements #1217

Merged
merged 5 commits into from
Apr 6, 2024
Merged

chore: cleanup and minor syntax improvements #1217

merged 5 commits into from
Apr 6, 2024

Conversation

Jint-lzxy
Copy link
Collaborator

This commit mainly tackled several minor touch-ups and syntax improvements:

  • Addressed luacheck issues from previous commits.
  • Added some to-do comments for _buf_vtext.
  • Eliminated redundant/outdated options.
  • Temporarily removed the ability to install nightly-version configs and updated the names of relevant functions: - clone_by_https_or_ssh -> clone_repo
  • Rewrote dotstutor to make it more readable.

This commit mainly tackled several minor touch-ups and syntax
improvements:

- Addressed `luacheck` issues from previous commits.
- Added some to-do comments for `_buf_vtext`.
- Eliminated redundant/outdated options.
- Temporarily removed the ability to install nightly-version configs
  and updated the names of relevant functions:
    - `clone_by_https_or_ssh` -> `clone_repo`
- Rewrote `dotstutor` to make it more readable.
Copy link
Owner

@ayamir ayamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayamir
Copy link
Owner

ayamir commented Apr 4, 2024

In fact, I'm trying to use vim.region() in neovim/neovim#13896 (comment) to get selected text but failed. And I also see a relevant PR about it: neovim/neovim#27578 and seem this api will be changed.
IMO current impl is enough for 0.9.

@Jint-lzxy
Copy link
Collaborator Author

65d580e further simplified the venv detection logic in dap/clients/python.lua.

@Jint-lzxy
Copy link
Collaborator Author

Jint-lzxy commented Apr 4, 2024

In fact, I'm trying to use vim.region() in ... to get selected text but failed. And I also see a relevant PR about it: ... and seem this api will be changed. IMO current impl is enough for 0.9.

Agreed. The new vim.getregion() is indeed more "reliable" due to its use of internal calls. Will update the to-do comment accordingly.

UPDATE: See 354ed80.

@ayamir ayamir merged commit f16aa25 into main Apr 6, 2024
4 checks passed
@ayamir ayamir deleted the chore/cleanups branch April 6, 2024 05:12
ttbug pushed a commit to ttbug/nvimconf that referenced this pull request Apr 12, 2024
* chore: cleanup and minor syntax improvements

This commit mainly tackled several minor touch-ups and syntax
improvements:

- Addressed `luacheck` issues from previous commits.
- Added some to-do comments for `_buf_vtext`.
- Eliminated redundant/outdated options.
- Temporarily removed the ability to install nightly-version configs
  and updated the names of relevant functions:
    - `clone_by_https_or_ssh` -> `clone_repo`
- Rewrote `dotstutor` to make it more readable.

* perf(debugpy): simplify venv detection logic

* fixup! chore: cleanup and minor syntax improvements

* fixup! Merge branch 'main' into chore/cleanups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants