feat(lspsaga & lualine): Show symbols in lualine.

[Jint-lzxy]

#398 (comment). This can solve rendering problems such as displaying 'cursorcolumn'. Symbol_in_winbar will cause the space between bufferline and the file to be inaccessible by built-in features.

This is a rough setup and should require additional testing 👍

[CharlesChiuGit]

I think a better way to do this is to include the filename in the winbar too, so it will always has a place holder for winbar.
Like this:

[Jint-lzxy]

I think a better way to do this is to include the filename in the winbar

IMO this is similar to the function of bufferline (and their location is very close). Besides, the problem of built-in rendering has not been resolved.

[CharlesChiuGit]

I agree with your view point.
But I don't think lualine supports click to jump at this moment?
If u place breadcrumbs in winbar, lspsaga has built-in support for click to jump.

[Jint-lzxy]

I have made adjustments to support click to jump 👍

nvimdots/lua/modules/completion/config.lua

Lines 106 to 127 in f08d88f

	click_support = function(node, clicks, button, modifiers)
	local st = node.range.start
	local en = node.range["end"]
	if button == "l" then
	if clicks == 2 then
	-- double left click to do nothing
	else -- jump to node's starting line+char
	vim.fn.cursor(st.line + 1, st.character + 1)
	end
	elseif button == "r" then
	if modifiers == "s" then
	print("symbol_winbar")
	end
	vim.fn.cursor(en.line + 1, en.character + 1)
	elseif button == "m" then
	-- middle click to visual select node
	vim.fn.cursor(st.line + 1, st.character + 1)
	vim.api.nvim_command([[normal v]])
	vim.fn.cursor(en.line + 1, en.character + 1)
	end
	end,
	},

This setting is position independent because lspsaga has already processed the formatted string when returning.

[CharlesChiuGit]

Also, IMO, the center section of lualine is more suitable for git-blames.

With this setup, we won't see git-blames floating around all the time which is very distracting.

[CharlesChiuGit]

I have made adjustments to support click to jump 👍

nvimdots/lua/modules/completion/config.lua

Lines 106 to 127 in f08d88f

	click_support = function(node, clicks, button, modifiers)
	local st = node.range.start
	local en = node.range["end"]
	if button == "l" then
	if clicks == 2 then
	-- double left click to do nothing
	else -- jump to node's starting line+char
	vim.fn.cursor(st.line + 1, st.character + 1)
	end
	elseif button == "r" then
	if modifiers == "s" then
	print("symbol_winbar")
	end
	vim.fn.cursor(en.line + 1, en.character + 1)
	elseif button == "m" then
	-- middle click to visual select node
	vim.fn.cursor(st.line + 1, st.character + 1)
	vim.api.nvim_command([[normal v]])
	vim.fn.cursor(en.line + 1, en.character + 1)
	end
	end,
	},

This setting is position independent because lspsaga has already processed the formatted string when returning.

Ok, that's pretty cool! Nice!

[Jint-lzxy]

With this setup, we won't see git-blames floating around all the time which is very distracting.

It is rendered as virtual text when you hover over a line :) Like so:

[CharlesChiuGit]

Yeah, it is virtual text. But it still makes me feel distracting, never mind, it's just my opinion. I'll keep it for myself.

[Jint-lzxy]

Yeah, it is virtual text. But it still makes me feel distracting, never mind, it's just my opinion. I'll keep it for myself.

Another reason for putting symbols here is there are no elements in the center of lualine now. Of course, rendering git blame is also a great idea 👍 Let's wait for @ayamir to review these changes :)

[CharlesChiuGit]

Besides, the problem of built-in rendering has not been resolved.

I don't think it's lspsaga's fault to blame. It's an upstream issue. In neovim nightly(0.9.0), the filename placeholder in winbar will always persist, but in 0.8.2, the rendering issue mentioned in #398 (comment) does exist.

In 0.9.0(nightly):

In 0.8.2(stable):

[Jint-lzxy]

I don't think it's lspsaga's fault to blame.

This occurs only when show_file = false is set.

The main issue is that currently lspsaga will occupy a space between bufferline and the file, and this space is independent of file rendering. This means that any built-in full-screen rendering feature (For example, rendering vertical bars that occupy the entire screen) will not touch bufferline (i.e., there will always be a gap between bufferline and the file if lspsaga doesn't render here)

[ayamir]

Nice feature! Always showing filename in winbar indeed duplicates with bufferline. Tested for click support and it works normally. I prefer to put getcwd to the right with this feature like this: