Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only disable autoclose for specific filetypes #916

Merged
merged 2 commits into from
Jul 31, 2023
Merged

fix: only disable autoclose for specific filetypes #916

merged 2 commits into from
Jul 31, 2023

Conversation

ayamir
Copy link
Owner

@ayamir ayamir commented Jul 31, 2023

  1. disable autoclose '' for rust because ' is the symbol for lifetimes.
  2. disable autoclose <> for cpp only because << and >> are operators in cpp but <> is often used as generic type.

@ayamir
fix: set autoclose properly for cpp&rust.
ad16047 
Signed-off-by: ayamir <lgt986452565@gmail.com>
@ayamir
fixup!: clean code.
07693a7
Jint-lzxy
Jint-lzxy approved these changes Jul 31, 2023
View reviewed changes
Copy link
Collaborator

@Jint-lzxy Jint-lzxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jint-lzxy Jint-lzxy changed the title fix: set autoclose properly for cpp&rust. fix: only disable autoclose for specific filetypes Jul 31, 2023
@ayamir ayamir merged commit 7a01d7a into main Jul 31, 2023
4 checks passed
@ayamir ayamir deleted the fix/autoclose branch July 31, 2023 10:43
singlemancombat pushed a commit to singlemancombat/nvim-config that referenced this pull request Jul 31, 2023
@ayamir @singlemancombat
fix: only disable autoclose for specific filetypes (ayamir#916)
ab8d301 
* fix: set autoclose properly for cpp&rust.

Signed-off-by: ayamir <lgt986452565@gmail.com>

* fixup!: clean code.

---------

Signed-off-by: ayamir <lgt986452565@gmail.com>
@TonyWu20 TonyWu20 mentioned this pull request Aug 2, 2023
Merged
@fecet
Copy link
Contributor

fecet commented Aug 7, 2023

Dosn't most languages use < and > for comparasion? I guess enable it only for specific filetypes would be better

@ayamir
Copy link
Owner Author

ayamir commented Aug 7, 2023 •
edited
Loading

Dosn't most languages use < and > for comparasion? I guess enable it only for specific filetypes would be better

You're right. But autoclose.nvim doesn't have the option to enable it for the specific file type. I have opened an issue for it here.

@Jint-lzxy
Copy link
Collaborator

You're right. But autoclose.nvim doesn't have the option to enable it for the specific file type. I have opened an issue for it here.

@ayamir IMO we can revert this change atm to avoid regression & repeated issues.

Jint-lzxy added a commit that referenced this pull request Aug 7, 2023
@Jint-lzxy
revert(autoclose): temporal fix for regression introduced by #916
bc73f31
@Jint-lzxy Jint-lzxy mentioned this pull request Aug 7, 2023
Merged
ayamir pushed a commit that referenced this pull request Aug 7, 2023
@Jint-lzxy
revert(autoclose): temporal fix for regression introduced by #916 (#935)
6cb0db3
singlemancombat pushed a commit to singlemancombat/nvim-config that referenced this pull request Aug 7, 2023
@Jint-lzxy @singlemancombat
revert(autoclose): temporal fix for regression introduced by ayamir#916…
c5f25ff 
… (ayamir#935)
@TonyWu20 TonyWu20 mentioned this pull request Aug 21, 2023
Merged
@TonyWu20 TonyWu20 mentioned this pull request Sep 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jint-lzxy Jint-lzxy Jint-lzxy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayamir @fecet @Jint-lzxy