Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better makefile #140

Merged
merged 41 commits into from
Aug 31, 2023
Merged

Better makefile #140

merged 41 commits into from
Aug 31, 2023

Conversation

pxp9
Copy link
Collaborator

@pxp9 pxp9 commented Aug 25, 2023

Improving makefile

@Dopplerian
proper alignment in Makefile
47a2f32
@Dopplerian
use diesel cli arguments in Makefile
c3ae656
@Dopplerian
fix mistake with diesel cli
bacca91
@Dopplerian
better organization
2407278
@Dopplerian
user/password consistency in Makefile
4d22be3
@Dopplerian
add .PHONY target
1ae01f7
@Dopplerian
move clippy target
75702dd
@Dopplerian
remove unnecessary environment variables
150fd44
@Dopplerian
fix problem from 4d22be3
eb6464c
@Dopplerian
maybe this is better for users/passwords
dfac909
@Dopplerian
fix fuck up again
e820335
@Dopplerian
better organization and wait for MySQL
b18b6f3
@Dopplerian
format README.md
a464fff
@Dopplerian
format README.md Rust code
b475dd0
@Dopplerian
update README.md
b609210
@Dopplerian
another probably better approach
107bc5d
@Dopplerian
better output
4c43b93
@Dopplerian
bold echoes
0b53531
@Dopplerian
update make doc
408f1b6
@Dopplerian
use variables in Makefile
4d7ff7f
@Dopplerian
use --migration-dir for Diesel
0585ad5
@Dopplerian
add variables for migrations
c829c1f
@Dopplerian
add fang/mysql_migrations/diesel.toml and use variables for Diesel …
e6704a1 
…config files
@Dopplerian
add default goal
94874d9
@Dopplerian
add .env recipe
65ea5d3
@Dopplerian
add variables for URLs of DBs
2ed78ce
@Dopplerian
format Makefile
af58b65
@Dopplerian
fix fuck-up in last commit
ced7be2
@Dopplerian
setup Makefile for parallel execution
18bccd7
@pxp9 pxp9 added the enhancement New feature or request label Aug 25, 2023
@pxp9 pxp9 marked this pull request as draft August 25, 2023 14:14
@pxp9 pxp9 requested a review from ayrat555 August 25, 2023 14:43
@Dopplerian Dopplerian marked this pull request as ready for review August 29, 2023 13:55
@Dopplerian
Copy link
Collaborator

With these changes, you would only need to do make -j db when you start working on the project, then you can do make -j tests and make -j ignored whenever you need to test your changes, and when you are finished working you may do make -j stop.

Note: -j flag is optional but recommended.

pxp9
pxp9 commented Aug 29, 2023
View reviewed changes
Copy link
Collaborator Author

@pxp9 pxp9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @Dopplerian

0xCAB0
0xCAB0 approved these changes Aug 29, 2023
View reviewed changes
Copy link
Collaborator

@0xCAB0 0xCAB0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good for me! Nice job

@pxp9
Copy link
Collaborator Author

pxp9 commented Aug 29, 2023

I would like to merge this to master and then merge it to my branch which I provide sqlx support

ayrat555
ayrat555 reviewed Aug 29, 2023
View reviewed changes
.env Show resolved Hide resolved
fang/README.md Outdated Show resolved Hide resolved
@Dopplerian
Copy link
Collaborator

@ayrat555 I think commit fc1b0c7 does what you wanted.

@Dopplerian Dopplerian requested a review from ayrat555 August 29, 2023 21:23
@Dopplerian Dopplerian self-requested a review August 30, 2023 10:43
@pxp9
Copy link
Collaborator Author

pxp9 commented Aug 30, 2023

Can this be merged ?

I would like to merge it also in my pr

@Dopplerian Dopplerian merged commit 1143285 into master Aug 31, 2023
@ayrat555 ayrat555 deleted the better-makefile branch August 31, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dopplerian Dopplerian Dopplerian approved these changes

@0xCAB0 0xCAB0 0xCAB0 approved these changes

@ayrat555 ayrat555 ayrat555 approved these changes

Assignees

@Dopplerian Dopplerian

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pxp9 @Dopplerian @ayrat555 @0xCAB0