Add makefile error if diesel_cli is not installed #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v0idpwn
commented
Sep 10, 2023
Comment on lines
+52
to
+53
| ensure_diesel: | ||
| @command -v diesel >/dev/null 2>&1 || (echo "diesel_cli not installed, can't continue" && exit 1) |
There was a problem hiding this comment.
I think maybe we could require ensure_diesel for db. It isn't really required, but in the current setup, the containers are started even if diesel_cli isn't installed, and they aren't automatically killed on error. This could be avoided by depending on ensure_diesel for db.
ayrat555
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
diesel_postgres,diesel_mysqlanddiesel_sqlitewill loop forever if the diesel_cli dependency isn't installed. This PR adds a step that verifies tha diesel_cli is installed and returns an error otherwise.