-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(cargo): update typed-builder requirement from 0.19 to 0.20 #195
Conversation
--- updated-dependencies: - dependency-name: typed-builder dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
What about switching to bon, which is inspired by typed-builder and has taken some learnings from it? Havnt looked deeper into it, just thought again about it. https://crates.io/crates/bon Its v2 Release also sparks the question… do we want the Into conversions? |
@EdJoPaTo I'm ok with switching if features are the same. what do you mean by "do we want the Into conversions?"? is it automatic in bon? I don't see anything against it |
bon v1 did Into automatically and removed this with v2. More reasoning here: https://elastio.github.io/bon/blog/bon-builder-generator-v2-release#removed-magical-automatic-into-conversions Which got me thinking whether it's a good idea to use the Into stuff or not. |
Hey, I found this mention of I described all the motivations and demotivations for using I looked at your usage of frankenstein/src/api_params.rs Lines 255 to 257 in 7d7b024
I can confidently say that Note that
|
I created a draft PR #196 with the migration. In that PR I just updated from the Right now, I have preserved the same builder configurations for
|
Looks like typed-builder is no longer a dependency, so this is no longer needed. |
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)