Create initial compliance test #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o loom.compliance-tester. Tests are now functions which accept an empty graph instance.
|
Fantastic! Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The simple tests from
loom.test.graphwere extracted toloom.compliance-testerand transformed to functions which take an empty graph. This empty graph can be used to build a graph for testing as long as it adheres to the required Loom protocols.This enables third-party implementations of Loom protocols to use the same tests as the default implementations.
These compliance tests could be further expanded, perhaps adding the tests from
loom.test.algwould be a practical way to maximize coverage.